Fixing design for user settings tabs #2
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,38 +1,27 @@ | ||
| <mat-card *ngFor="let bookmark of settings.bookmarks; let index = index"> | ||
| <mat-card-content> | ||
| <div class="url-toggle"> | ||
| <mat-form-field> | ||
| <mat-label>{{ 'bookmark.url' | translate }}</mat-label> | ||
| <input matInput [(ngModel)]="bookmark.url" /> | ||
| </mat-form-field> | ||
| <mat-slide-toggle [checked]="bookmark.external" (change)="bookmark.external = $event.checked"> | ||
| {{ 'bookmark.external' | translate }} | ||
| </mat-slide-toggle> | ||
| </div> | ||
| <app-accelerator [label]="'app.shortcut' | translate" [(value)]="bookmark.shortcut"> | ||
| </app-accelerator> | ||
| </mat-card-content> | ||
| <mat-card-actions> | ||
| <button mat-button (click)="onRemoveClick(index)">Remove</button> | ||
| </mat-card-actions> | ||
| </mat-card> | ||
| <div class="bookmark-actions"> | ||
| <button mat-raised-button (click)="onAddClick()"> | ||
| {{ 'bookmark.add' | translate }} | ||
| </button> | ||
| <button mat-raised-button (click)="ghostInput.click()"> | ||
| {{ 'bookmark.add-file' | translate }} | ||
| </button> | ||
| <input hidden #ghostInput type="file" (change)="onFileSelected($event)" /> | ||
| </div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,17 @@ | ||
| :host { | ||
| display: grid; | ||
| grid-template-columns: repeat(2, 1fr); | ||
| gap: 12px; | ||
| } | ||
|
|
||
| .url-toggle { | ||
| display: flex; | ||
| gap: 32px; | ||
| align-items: center; | ||
| } | ||
|
|
||
| .bookmark-actions { | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: 8px; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,26 +1,19 @@ | ||
| <mat-card *ngFor="let command of settings.commands; let index = index"> | ||
| <mat-card-content> | ||
| <mat-form-field matTooltip="{{ 'command.text-description' | translate }}" | ||
| matTooltipClass="width-450"> | ||
| <mat-label>{{ 'command.text' | translate }}</mat-label> | ||
| <input matInput [(ngModel)]="command.text" /> | ||
| </mat-form-field> | ||
| <app-accelerator [label]="'app.shortcut' | translate" [(value)]="command.shortcut"> | ||
| </app-accelerator> | ||
| </mat-card-content> | ||
| <mat-card-actions> | ||
| <button mat-button (click)="onRemoveClick(index)"> | ||
| Remove | ||
| </button> | ||
| </mat-card-actions> | ||
| </mat-card> | ||
| <button mat-raised-button (click)="onAddCommandClick()"> | ||
| {{ 'command.add' | translate }} | ||
| </button> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,15 @@ | ||
| :host { | ||
| display: grid; | ||
| grid-template-columns: repeat(3, 1fr); | ||
| gap: 12px; | ||
| } | ||
|
|
||
| ::ng-deep { | ||
|
Collaborator
Author
There was a problem hiding this comment. i don't like this but i didn't think of a better solution at the time. i will do a pass on a lot of nit picky stuff when we get near the end of 1.0 |
||
| .mat-mdc-tooltip { | ||
| white-space: pre-line; | ||
|
|
||
| &.width-450 .mat-mdc-tooltip-surface { | ||
| max-width: 450px; | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this prevents the commonJS warning in the console. it doesn't "solve" anything