Skip to content

[FIX] Handover error logs #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shailesh351 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[FIX] Handover error logs #180

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
508d9e3
Fix handover error logs
Shailesh351 Dec 12, 2022
f9fd295
Fix lint issue
Shailesh351 Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/Room.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ export const updateRoomCustomFields = async (rid: string, data: IRoomCustomField
export const updateRoomSNSData = async (read: IRead, modify: IModify, rid: string, data: Record<string, unknown>, isLog = false): Promise<void> => {
const customFields = await getRoomCustomFields(rid, read);
if (customFields) {
const snsData = Object.assign({}, (customFields.sns || {}) as Record<string, unknown>) ;
const logData = Object.assign({}, snsData.logData || {})
const snsData = Object.assign({}, (customFields.sns || {}) as Record<string, unknown>);
const logData = Object.assign({}, snsData.logData || {});
if (isLog) {
snsData.logData = Object.assign(logData, data);
} else {
Expand Down Expand Up @@ -152,7 +152,7 @@ export const performHandover = async (
const offlineMessage: string = await getLivechatAgentConfig(read, rid, AppSetting.DialogflowHandoverFailedMessage);
const handoverFailure = {
error: error || offlineMessage,
errorMessage: 'Unable to reach Liveagent bot, it may be offline or disabled.',
errorMessage: closeChatDesc,
dialogflow_SessionID: rid,
visitorDetails: (({ id, token }) => ({ id, token }))(visitor),
targetDepartment: livechatTransferData.targetDepartment,
Expand Down Expand Up @@ -218,7 +218,7 @@ export const performHandover = async (
});

if (!result) {
await handleHandoverFailure('', closeChatDesc);
await handleHandoverFailure(Logs.HANDOVER_REQUEST_FAILED_ERROR, closeChatDesc);
return false;
}

Expand Down