don't use jemalloc for Windows targets#943
Merged
Wilfred merged 1 commit intoWilfred:masterfrom Feb 16, 2026
Merged
Conversation
I tried to add difftastic package in MSYS2, but I didn't manage to get successful build of jemalloc-sys on windows-gnu. I'll try to investigate it later, for now I suggest to just not use jemalloc for all Windows targets
Owner
|
Seems reasonable, thanks. All the allocators have been really tricky to use when I'm trying to support all the major platforms. FWIW jemalloc's docs do suggest limiting to msvc, but I've no objection to covering all Windows. I'd rather the build works even if it costs some runtime performance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to add difftastic package in msys2/MINGW-packages#27535, but I didn't manage to get successful build of jemalloc-sys on windows-gnu. I'll try to investigate it later, for now I suggest to just not use jemalloc for all Windows targets