Skip to content
This repository was archived by the owner on Nov 27, 2025. It is now read-only.

fix: treat not found errors #48

Merged
exKAZUu merged 10 commits into from
Jun 6, 2019
Merged

fix: treat not found errors #48

exKAZUu merged 10 commits into from
Jun 6, 2019

Conversation

@kumachan-mis
Copy link
Collaborator

@kumachan-mis kumachan-mis commented Jun 6, 2019 •
edited
Loading

close #47

@kumachan-mis kumachan-mis requested a review from exKAZUu June 6, 2019 02:32
@kumachan-mis
Copy link
Collaborator Author

kumachan-mis commented Jun 6, 2019

@exKAZUu
削除については, どうしましょうか？
今のところは, ファイルの削除のdiffは無視するように, $diffBlockのクラス名を設定しています

plantuml-visualizer/src/GitHubFinder.ts

Line 77 in 72b8c48

const $diffBlock = $diff.find('div.data.highlight.js-blob-wrapper');

@exKAZUu
Copy link
Member

exKAZUu commented Jun 6, 2019

@kumachan-mis 一応、削除されるUMLも可視化してもらえると助かる！

exKAZUu
exKAZUu reviewed Jun 6, 2019
View reviewed changes
@kumachan-mis kumachan-mis requested a review from exKAZUu June 6, 2019 05:12
exKAZUu
exKAZUu approved these changes Jun 6, 2019
View reviewed changes
Copy link
Member

@exKAZUu exKAZUu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@exKAZUu exKAZUu merged commit 6c2fd65 into master Jun 6, 2019
@exKAZUu exKAZUu deleted the 47_fix_not_found_error branch June 6, 2019 06:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@exKAZUu exKAZUu exKAZUu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

An Error occurs when new UML files are created in a PR

3 participants

@kumachan-mis @exKAZUu