fix: fix normalizeScript #553
Conversation
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Summary of ChangesHello @exKAZUu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| ): Promise<number> { | ||
| const [printableScript, runnableScript] = normalizeScript(script, project); | ||
| printStart(printableScript, project); | ||
| const normalizedScript = normalizeScript(script, project); |
There was a problem hiding this comment.
オブジェクトの分割代入を利用すると、normalizedScript という中間変数をなくし、コードをより簡潔にできます。const { printable, runnable } = normalizeScript(script, project); のように変更し、以降の normalizedScript.printable と normalizedScript.runnable をそれぞれ printable と runnable に置き換えることを検討してください。
| return promisePool.runAndWaitForReturnValue(async () => { | ||
| const [printableScript, runnableScript] = normalizeScript(script, project); | ||
| printStart(printableScript, project, 'Start (parallel)', true); | ||
| const normalizedScript = normalizeScript(script, project); |
There was a problem hiding this comment.
こちらの関数でも runWithSpawn と同様に、オブジェクトの分割代入を利用してコードを簡潔にすることを検討してください。
| // Add cascade option when WB_ENV is defined | ||
| const cascadeOption = project.env.WB_ENV ? ` --cascade-env=${project.env.WB_ENV || 'development'}` : ''; | ||
| return [`${packageManagerWithRun} dotenv${cascadeOption} -- ${printableScript}`, runnableScript]; | ||
| const cascadeOption = project.env.WB_ENV ? ` -c=${project.env.WB_ENV || 'development'}` : ''; |
There was a problem hiding this comment.
可読性の観点から、短い形式の -c よりも、意味が明確な --cascade-env を使用することを推奨します。これにより、オプションの目的がコードを読むだけで理解しやすくなります。
| const cascadeOption = project.env.WB_ENV ? ` -c=${project.env.WB_ENV || 'development'}` : ''; | |
| const cascadeOption = project.env.WB_ENV ? ` --cascade-env=${project.env.WB_ENV || 'development'}` : ''; |
There was a problem hiding this comment.
Pull request overview
This PR refactors the normalizeScript function to improve code clarity by changing its return type from a tuple [string, string] to a named object { printable: string; runnable: string }. The change makes the purpose of each returned value more explicit and easier to understand. Additionally, the PR attempts to shorten the cascade option flag from --cascade-env= to -c=.
Key changes:
- Refactored
normalizeScriptreturn type from tuple to named object for better code readability - Updated all call sites to use object destructuring instead of array destructuring
- Changed cascade option flag from
--cascade-env=to-c=(potentially incorrect)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // Add cascade option when WB_ENV is defined | ||
| const cascadeOption = project.env.WB_ENV ? ` --cascade-env=${project.env.WB_ENV || 'development'}` : ''; | ||
| return [`${packageManagerWithRun} dotenv${cascadeOption} -- ${printableScript}`, runnableScript]; | ||
| const cascadeOption = project.env.WB_ENV ? ` -c=${project.env.WB_ENV || 'development'}` : ''; |
There was a problem hiding this comment.
The change from --cascade-env= to -c= appears to be incorrect. The yargsOptionsBuilderForEnv in packages/shared-lib-node/src/env.ts defines the option as cascade-env without any short alias like -c. Using -c= would likely cause the option to not be recognized by the dotenv command.
This should remain as --cascade-env= unless a corresponding alias has been added to the option definition.
| const cascadeOption = project.env.WB_ENV ? ` -c=${project.env.WB_ENV || 'development'}` : ''; | |
| const cascadeOption = project.env.WB_ENV ? ` --cascade-env=${project.env.WB_ENV || 'development'}` : ''; |
Close #
Self Check
All checks have passedon this page.WIP:.yarn test) passed.yarn lint) passed.