-
Notifications
You must be signed in to change notification settings - Fork 0
chore: willboosterify this repo #573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,24 +2,37 @@ | |
|
|
||
| - Name: willbooster-shared | ||
| - Description: undefined | ||
| - Package Manager: yarn | ||
| - Package Manager: yarn on zsh | ||
|
|
||
| ## General Instructions | ||
| ## Development Workflow | ||
|
|
||
| - Do not write tests unless explicitly requested. | ||
| - When fixing tests, gather debug information through logging and screenshots before modifying the code. | ||
| - After making code changes, run `yarn check-all-for-ai` to execute all tests (note: this may take up to 30 minutes), or run `yarn check-for-ai` for type checking and linting only. | ||
| - If you are confident your changes will not break any tests, you may use `check-for-ai`. | ||
| - Once you have verified your changes, commit them to the non-main branch using the `--no-verify` option and push to the current branch. | ||
| - Follow conventional commits, i.e., your commit message should start with `feat:`, `fix:`, etc. | ||
| - Make sure to add a new line at the end of your commit message with: `Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>`. | ||
| - Always create new commits. Avoid using `--amend`. | ||
| When changing code, complete these steps before responding to the user. | ||
|
|
||
| 1. If the current branch is `main`, create a new branch. | ||
| - Include unexpected changes since they are mine. | ||
| 2. Make code changes as needed. | ||
| 3. If possible, write e2e tests for your changes. | ||
| 4. Fix your changes until `yarn check-all-for-ai` (running all tests, taking 30 mins) or `yarn check-for-ai` (only type checking and linting) passes. | ||
| - If you are confident your changes will not break any tests, you may use `check-for-ai`. | ||
| 5. Commit your changes to the current branch and push. | ||
| - Follow conventional commits, i.e., your commit message should start with `feat:`, `fix:`, `test:`, etc. | ||
| - Make sure to add a new line at the end of your commit message with: `Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>`. | ||
| - When pre-commit hooks prevent your changes, fix your code, then re-commit and re-push. | ||
| 6. Create a pull request using `gh`. | ||
| - The pull request title should match your commit message. | ||
| 7. Repeat the following steps until the test workflow passes: | ||
| 1. Monitor the CI results using the following command until the test workflow completes (timeout should be 30 mins). | ||
| - `while :; do gh run list -b "$(git branch --show-current)" --json status,conclusion | jq -e '.[] | select(.conclusion=="failure")' && exit 1; gh run list -b "$(git branch --show-current)" --json status | jq -e '.[] | select(.status=="completed" | not)' || exit 0; sleep 1m; done` | ||
| 2. If tests fail, identify the root causes by gathering debug information through logging and screenshots, then fix the code and/or tests. | ||
| 3. Fetch unresolved review comments from the pull request using the following command. Address them and then mark them as resolved. | ||
| - `gh api graphql -f query="{ repository(owner: \"WillBooster\", name: \"shared\") { pullRequest(number: $(gh pr view --json number -q .number)) { reviewThreads(first: 100) { nodes { isResolved comments(first: 100) { nodes { body author { login } path line } } } } } } }" | jq '.data.repository.pullRequest.reviewThreads.nodes[] | select(.isResolved | not)'` | ||
| 4. Commit your changes and push. | ||
| 5. Write `/gemini review` in the pull request. | ||
|
|
||
| ## Coding Style | ||
|
|
||
| - Write comments that explain "why" rather than "what". Avoid explanations that can be understood from the code itself. | ||
| - Use stderr for logging debug messages temporarily since stdout output is sometimes omitted. | ||
| - When adding new functions or classes, define them below any functions or classes that call them to maintain clear call order. | ||
| - Prefer `undefined` over `null` unless explicitly dealing with APIs or libraries that require `null`. | ||
| - Always perform existence checks on array due to `noUncheckedIndexedAccess: true`. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| - Use `project.env` instead of `process.env` on `wb` package. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,24 +2,37 @@ | |
|
|
||
| - Name: willbooster-shared | ||
| - Description: undefined | ||
| - Package Manager: yarn | ||
| - Package Manager: yarn on zsh | ||
|
|
||
| ## General Instructions | ||
| ## Development Workflow | ||
|
|
||
| - Do not write tests unless explicitly requested. | ||
| - When fixing tests, gather debug information through logging and screenshots before modifying the code. | ||
| - After making code changes, run `yarn check-all-for-ai` to execute all tests (note: this may take up to 30 minutes), or run `yarn check-for-ai` for type checking and linting only. | ||
| - If you are confident your changes will not break any tests, you may use `check-for-ai`. | ||
| - Once you have verified your changes, commit them to the non-main branch using the `--no-verify` option and push to the current branch. | ||
| - Follow conventional commits, i.e., your commit message should start with `feat:`, `fix:`, etc. | ||
| - Make sure to add a new line at the end of your commit message with: `Co-authored-by: WillBooster (Claude Code) <agent@willbooster.com>`. | ||
| - Always create new commits. Avoid using `--amend`. | ||
| When changing code, complete these steps before responding to the user. | ||
|
|
||
| 1. If the current branch is `main`, create a new branch. | ||
| - Include unexpected changes since they are mine. | ||
| 2. Make code changes as needed. | ||
| 3. If possible, write e2e tests for your changes. | ||
| 4. Fix your changes until `yarn check-all-for-ai` (running all tests, taking 30 mins) or `yarn check-for-ai` (only type checking and linting) passes. | ||
| - If you are confident your changes will not break any tests, you may use `check-for-ai`. | ||
| 5. Commit your changes to the current branch and push. | ||
| - Follow conventional commits, i.e., your commit message should start with `feat:`, `fix:`, `test:`, etc. | ||
| - Make sure to add a new line at the end of your commit message with: `Co-authored-by: WillBooster (Claude Code) <agent@willbooster.com>`. | ||
| - When pre-commit hooks prevent your changes, fix your code, then re-commit and re-push. | ||
| 6. Create a pull request using `gh`. | ||
| - The pull request title should match your commit message. | ||
| 7. Repeat the following steps until the test workflow passes: | ||
| 1. Monitor the CI results using the following command until the test workflow completes (timeout should be 30 mins). | ||
| - `while :; do gh run list -b "$(git branch --show-current)" --json status,conclusion | jq -e '.[] | select(.conclusion=="failure")' && exit 1; gh run list -b "$(git branch --show-current)" --json status | jq -e '.[] | select(.status=="completed" | not)' || exit 0; sleep 1m; done` | ||
| 2. If tests fail, identify the root causes by gathering debug information through logging and screenshots, then fix the code and/or tests. | ||
| 3. Fetch unresolved review comments from the pull request using the following command. Address them and then mark them as resolved. | ||
| - `gh api graphql -f query="{ repository(owner: \"WillBooster\", name: \"shared\") { pullRequest(number: $(gh pr view --json number -q .number)) { reviewThreads(first: 100) { nodes { isResolved comments(first: 100) { nodes { body author { login } path line } } } } } } }" | jq '.data.repository.pullRequest.reviewThreads.nodes[] | select(.isResolved | not)'` | ||
| 4. Commit your changes and push. | ||
| 5. Write `/gemini review` in the pull request. | ||
|
|
||
| ## Coding Style | ||
|
|
||
| - Write comments that explain "why" rather than "what". Avoid explanations that can be understood from the code itself. | ||
| - Use stderr for logging debug messages temporarily since stdout output is sometimes omitted. | ||
| - When adding new functions or classes, define them below any functions or classes that call them to maintain clear call order. | ||
| - Prefer `undefined` over `null` unless explicitly dealing with APIs or libraries that require `null`. | ||
| - Always perform existence checks on array due to `noUncheckedIndexedAccess: true`. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| - Use `project.env` instead of `process.env` on `wb` package. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,24 +2,37 @@ | |
|
|
||
| - Name: willbooster-shared | ||
| - Description: undefined | ||
| - Package Manager: yarn | ||
| - Package Manager: yarn on zsh | ||
|
|
||
| ## General Instructions | ||
| ## Development Workflow | ||
|
|
||
| - Do not write tests unless explicitly requested. | ||
| - When fixing tests, gather debug information through logging and screenshots before modifying the code. | ||
| - After making code changes, run `yarn check-all-for-ai` to execute all tests (note: this may take up to 30 minutes), or run `yarn check-for-ai` for type checking and linting only. | ||
| - If you are confident your changes will not break any tests, you may use `check-for-ai`. | ||
| - Once you have verified your changes, commit them to the non-main branch using the `--no-verify` option and push to the current branch. | ||
| - Follow conventional commits, i.e., your commit message should start with `feat:`, `fix:`, etc. | ||
| - Make sure to add a new line at the end of your commit message with: `Co-authored-by: WillBooster (Gemini CLI) <agent@willbooster.com>`. | ||
| - Always create new commits. Avoid using `--amend`. | ||
| When changing code, complete these steps before responding to the user. | ||
|
|
||
| 1. If the current branch is `main`, create a new branch. | ||
| - Include unexpected changes since they are mine. | ||
| 2. Make code changes as needed. | ||
| 3. If possible, write e2e tests for your changes. | ||
| 4. Fix your changes until `yarn check-all-for-ai` (running all tests, taking 30 mins) or `yarn check-for-ai` (only type checking and linting) passes. | ||
| - If you are confident your changes will not break any tests, you may use `check-for-ai`. | ||
| 5. Commit your changes to the current branch and push. | ||
| - Follow conventional commits, i.e., your commit message should start with `feat:`, `fix:`, `test:`, etc. | ||
| - Make sure to add a new line at the end of your commit message with: `Co-authored-by: WillBooster (Gemini CLI) <agent@willbooster.com>`. | ||
| - When pre-commit hooks prevent your changes, fix your code, then re-commit and re-push. | ||
| 6. Create a pull request using `gh`. | ||
| - The pull request title should match your commit message. | ||
| 7. Repeat the following steps until the test workflow passes: | ||
| 1. Monitor the CI results using the following command until the test workflow completes (timeout should be 30 mins). | ||
| - `while :; do gh run list -b "$(git branch --show-current)" --json status,conclusion | jq -e '.[] | select(.conclusion=="failure")' && exit 1; gh run list -b "$(git branch --show-current)" --json status | jq -e '.[] | select(.status=="completed" | not)' || exit 0; sleep 1m; done` | ||
| 2. If tests fail, identify the root causes by gathering debug information through logging and screenshots, then fix the code and/or tests. | ||
| 3. Fetch unresolved review comments from the pull request using the following command. Address them and then mark them as resolved. | ||
| - `gh api graphql -f query="{ repository(owner: \"WillBooster\", name: \"shared\") { pullRequest(number: $(gh pr view --json number -q .number)) { reviewThreads(first: 100) { nodes { isResolved comments(first: 100) { nodes { body author { login } path line } } } } } } }" | jq '.data.repository.pullRequest.reviewThreads.nodes[] | select(.isResolved | not)'` | ||
| 4. Commit your changes and push. | ||
| 5. Write `/gemini review` in the pull request. | ||
|
|
||
| ## Coding Style | ||
|
|
||
| - Write comments that explain "why" rather than "what". Avoid explanations that can be understood from the code itself. | ||
| - Use stderr for logging debug messages temporarily since stdout output is sometimes omitted. | ||
| - When adding new functions or classes, define them below any functions or classes that call them to maintain clear call order. | ||
| - Prefer `undefined` over `null` unless explicitly dealing with APIs or libraries that require `null`. | ||
| - Always perform existence checks on array due to `noUncheckedIndexedAccess: true`. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| - Use `project.env` instead of `process.env` on `wb` package. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noUncheckedIndexedAccess: trueのための配列存在チェックを推奨するルールが削除されています。もし
tsconfig.jsonのnoUncheckedIndexedAccessがtrueのままであれば、このルールを削除すると、開発者(またはAI)が配列アクセス時にundefinedの可能性を考慮し忘れることで、ランタイムエラーを引き起こす危険性があります。tsconfig.jsonの設定がfalseに変更されたのでなければ、このルールの削除は再検討することをお勧めします。