You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi,
to my understanding, show_streamer_image should also show the image even if the streamer isnt live if set to true. Should be fixed with this request.
Hey! Thanks for your MR.
Doesn't setting live_only to false give you the intended result? This should show streamers that aren't live too. Maybe I'm misunderstanding what you're trying to achieve
I dont think so. Its not about the complete streamer div. Its only about the image of the streamer. Before I couldnt get the image of the streamer to show when the streamer was offline (with the greyed out image) no matter what value "show_streamer_image" holds and I think this was not intended. I expected the greyed out image to show when show_streamer_image=true and the streamer is offline. Live_only is always false in this scenario.
With the changes the image also shows when the streamer is off (or on) and show_streamer_image=true. But maybe Im missunderstanding what show_streamer_image=true should do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
to my understanding, show_streamer_image should also show the image even if the streamer isnt live if set to true. Should be fixed with this request.