Skip to content

fixed show_streamer_image bug#5

Open
N0thingSpecial wants to merge 1 commit intoWilliamFitzjohn:mainfrom
N0thingSpecial:main
Open

fixed show_streamer_image bug#5
N0thingSpecial wants to merge 1 commit intoWilliamFitzjohn:mainfrom
N0thingSpecial:main

Conversation

@N0thingSpecial
Copy link
Copy Markdown

Hi,
to my understanding, show_streamer_image should also show the image even if the streamer isnt live if set to true. Should be fixed with this request.

@WilliamFitzjohn
Copy link
Copy Markdown
Owner

Hey! Thanks for your MR.
Doesn't setting live_only to false give you the intended result? This should show streamers that aren't live too. Maybe I'm misunderstanding what you're trying to achieve

@N0thingSpecial
Copy link
Copy Markdown
Author

I dont think so. Its not about the complete streamer div. Its only about the image of the streamer. Before I couldnt get the image of the streamer to show when the streamer was offline (with the greyed out image) no matter what value "show_streamer_image" holds and I think this was not intended. I expected the greyed out image to show when show_streamer_image=true and the streamer is offline. Live_only is always false in this scenario.
With the changes the image also shows when the streamer is off (or on) and show_streamer_image=true. But maybe Im missunderstanding what show_streamer_image=true should do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants