uplay: update workarounds #1249

Kreyren · 2019-06-06T14:45:09Z

As refferenced on PhoenicisOrg/scripts#978 uplay needs application settings on winvista for upc.exe and UbisoftGameLauncher.exe to avoid rendering issues (PhoenicisOrg/scripts#965 (comment)).

Reproduced this issue on winetricks using wine-4.9 (Staging) on debian buster.

EDIT: Updated based on previous results, not tested.

EDIT2: Tested working on my system as presented in comments.

src/winetricks

austin987

Triaging.

Kreyren · 2019-09-12T08:10:42Z

Triaging.

oh shi!@#, sorry forgot about this, required changes are submitted.

Note that this is not tested since my current system is unable to reproduce the issue (system without GPU). Fix is submitted based on previous results.

austin987

Please squash the commits.

src/winetricks

Kreyren · 2019-09-13T07:50:25Z

I set up a system to test this.

aptli: http://ix.io/1UYd

Issue still present (uplay window):

Issue present with presented fix -> Assuming that Win7 environment might be affecting this -> investigating

winxp environment using winxp seems to resolve this

Confirmed fix using winxp environment and upc.exe + UbisoftGameLauncher.exe set on winvista.

Investigating to avoid using winxp globally -> Set the uplay executables with variation of different environments, but the result is as follows:

The client seems to works even with this message.

Seems that UplayWebCore.exe is the problem for rendering issues.

NSIS Error

Reproducable: always assuming new wineprefix

Current results with output https://gist.githubusercontent.com/Kreyren/97ca590d0131ed3a23b4646d2e8b8898/raw/c947adf9f99febd96623804975b8187d2a9c3a04/gagafd and popup:

---------------------------
NSIS Error
---------------------------
Installer integrity check has failed. Common causes include
incomplete download and damaged media. Contact the
installer's author to obtain a new copy.

More information at:
http://nsis.sf.net/NSIS_Error
---------------------------
OK   
---------------------------

This seems as new issue, investigating -> Resolved

References
https://ubuntuforums.org/showthread.php?t=1754649 - Points to corrupted file on upstream.
https://nsis.sourceforge.io/Why_do_I_get_NSIS_Error - Points to corrupted file on upstream.
https://www.winehq.org/pipermail/wine-users/2009-February/048568.html - Possible workaround
Solved NSIS issue

kreyren@dreamon:~$ rm .cache/winetricks/uplay/ -r
kreyren@dreamon:~$ /usr/src/winetricks/src/winetricks uplay
------------------------------------------------------
You are using a 64-bit WINEPREFIX. Note that many verbs only install 32-bit versions of packages. If you encounter problems, please retest in a clean 32-bit WINEPREFIX before reporting a bug.
------------------------------------------------------
Using winetricks 20190912-next - sha256sum: 61cac187f6dfcd3fec8942694f0809e321db4c320b4e6e1af1c6bf776d79c279 with wine-4.15 (Staging) and WINEARCH=win64
Executing w_do_call uplay
Executing load_uplay 
Executing mkdir -p /home/kreyren/.cache/winetricks/uplay
Executing cd /home/kreyren/.cache/winetricks/uplay
Downloading https://static3.cdn.ubi.com/orbit/launcher_installer/UplayInstaller.exe to /home/kreyren/.cache/winetricks/uplay
--2019-09-13 03:04:57--  https://static3.cdn.ubi.com/orbit/launcher_installer/UplayInstaller.exe
Resolving static3.cdn.ubi.com (static3.cdn.ubi.com)... 2.17.13.158
Connecting to static3.cdn.ubi.com (static3.cdn.ubi.com)|2.17.13.158|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 103654440 (99M) [application/octet-stream]
Saving to: ���UplayInstaller.exe���

UplayInstaller.exe  100%[===================>]  98.85M  15.8MB/s    in 6.2s    

2019-09-13 03:05:03 (16.0 MB/s) - ���UplayInstaller.exe��� saved [103654440/103654440]

Executing cd /home/kreyren
Executing cd /home/kreyren/.cache/winetricks/uplay
Executing wine UplayInstaller.exe
000b:fixme:thread:create_user_shared_data_thread Creating user shared data update thread.
000b:fixme:winediag:start_process Wine Staging 4.15 is a testing version containing experimental patches.
000b:fixme:winediag:start_process Please mention your exact version when filing bug reports on winehq.org.
000f:fixme:thread:create_user_shared_data_thread Creating user shared data update thread.
000d:fixme:thread:create_user_shared_data_thread Creating user shared data update thread.
0012:fixme:thread:create_user_shared_data_thread Creating user shared data update thread.
0014:fixme:thread:create_user_shared_data_thread Creating user shared data update thread.
001b:fixme:thread:create_user_shared_data_thread Creating user shared data update thread.
0021:fixme:thread:create_user_shared_data_thread Creating user shared data update thread.
<installer launches>

Kreyren · 2019-09-13T07:50:47Z

oops, synced wrong branch.

EDIT: fixed

Kreyren · 2019-09-13T08:07:57Z

@austin987 for solution in #1249 (comment) Should i make some logic to remove said file based on file's modify date to prevent similar issues?

EDIT: probably for another MR

Kreyren · 2019-09-13T09:23:46Z

INFO: Seems that w_set_app_winver() is not creating expected environment.

EDIT: confirmed

EDIT2: pebcak

Kreyren · 2019-09-13T09:58:56Z

@austin987 Ready for review this works on my system without issues so far excluding annoying pop-up message about crash within the uplay which doesn't prevent the wineapp from working.

loannaflip

cool

Attempt to work around rendering issues. As referenced on PhoenicisOrg/scripts#978 uplay needs application settings on `winvista` for `upc.exe` and `UbisoftGameLauncher.exe` to avoid rendering issues (PhoenicisOrg/scripts#965 (comment)). NOTICE: Outputs fatal error which is non-fatal, but i'm unable to stop it from appearing. Signed-off-by: Jacob Hrbek <werifgx@gmail.com>

Kreyren · 2019-09-14T05:38:06Z

minor edit

Attempt to add backend for uplay, tested locally Depends on: Winetricks#1249 Signed-off-by: Jacob Hrbek <kreyren@rixotstudio.cz>

Compatibility for 'Tom Clancy's Splinter Cell: Blacklist' for uplay Tested using commits below DEPENDS: Winetricks#1332 DEPENDS: Winetricks#1249 Signed-off-by: Jacob Hrbek <kreyren@rixotstudio.cz>

Attempt to add backend for uplay, tested locally Depends on: Winetricks#1249 Signed-off-by: Jacob Hrbek <kreyren@rixotstudio.cz>

Compatibility for 'Tom Clancy's Splinter Cell: Blacklist' for uplay Tested using commits below DEPENDS: Winetricks#1332 DEPENDS: Winetricks#1249 Signed-off-by: Jacob Hrbek <kreyren@rixotstudio.cz>

Attempt to add backend for uplay, tested locally Depends on: Winetricks#1249 Signed-off-by: Jacob Hrbek <kreyren@rixotstudio.cz>

austin987 reviewed Jun 8, 2019

View reviewed changes

src/winetricks Outdated Show resolved Hide resolved

austin987 requested changes Sep 12, 2019

View reviewed changes

Kreyren marked this pull request as ready for review September 12, 2019 08:11

austin987 requested changes Sep 12, 2019

View reviewed changes

src/winetricks Outdated Show resolved Hide resolved

src/winetricks Show resolved Hide resolved

Kreyren force-pushed the uplay branch from 8ff14ba to e83d6ce Compare September 13, 2019 07:50

Kreyren force-pushed the uplay branch from e83d6ce to 77894a7 Compare September 13, 2019 07:54

Kreyren force-pushed the uplay branch from 77894a7 to 08b802a Compare September 13, 2019 08:27

Kreyren mentioned this pull request Sep 13, 2019

Seems that w_set_app_winver() is not creating expected environment. #1317

Closed

Kreyren force-pushed the uplay branch from 08b802a to 327c4c8 Compare September 13, 2019 09:56

loannaflip reviewed Sep 13, 2019

View reviewed changes

Kreyren force-pushed the uplay branch from 327c4c8 to 3798b49 Compare September 14, 2019 05:38

Kreyren mentioned this pull request Sep 22, 2019

w_uplay_install_game: init #1332

Closed

Kreyren pushed a commit to Kreytricks/kreytricks that referenced this pull request Sep 22, 2019

w_uplay_install_game: init

3f137a3

Attempt to add backend for uplay, tested locally Depends on: Winetricks#1249 Signed-off-by: Jacob Hrbek <kreyren@rixotstudio.cz>

Kreyren mentioned this pull request Sep 22, 2019

tcscbl_uplay: init #1333

Closed

Kreyren mentioned this pull request Sep 22, 2019

splintercell_blacklist_uplay: init #1334

Closed

Kreyren pushed a commit to Kreytricks/kreytricks that referenced this pull request Sep 22, 2019

w_uplay_install_game: init

c6717f3

Attempt to add backend for uplay, tested locally Depends on: Winetricks#1249 Signed-off-by: Jacob Hrbek <kreyren@rixotstudio.cz>

Kreyren pushed a commit to Kreytricks/kreytricks that referenced this pull request Oct 21, 2019

w_uplay_install_game: init

30a229a

Attempt to add backend for uplay, tested locally Depends on: Winetricks#1249 Signed-off-by: Jacob Hrbek <kreyren@rixotstudio.cz>

austin987 closed this Nov 20, 2019

Uh oh!

uplay: update workarounds #1249

uplay: update workarounds #1249

Uh oh!

Conversation

Kreyren commented Jun 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

austin987 left a comment

Choose a reason for hiding this comment

Uh oh!

Kreyren commented Sep 12, 2019

Uh oh!

austin987 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Kreyren commented Sep 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

NSIS Error

Uh oh!

Kreyren commented Sep 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kreyren commented Sep 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kreyren commented Sep 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kreyren commented Sep 13, 2019

Uh oh!

loannaflip left a comment

Choose a reason for hiding this comment

Uh oh!

Kreyren commented Sep 14, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Kreyren commented Jun 6, 2019 •

edited

Loading

Kreyren commented Sep 13, 2019 •

edited

Loading

Kreyren commented Sep 13, 2019 •

edited

Loading

Kreyren commented Sep 13, 2019 •

edited

Loading

Kreyren commented Sep 13, 2019 •

edited

Loading