Two Handhake initiation releated race-conditions fixed #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drgkaleda
commented
May 20, 2021
drgkaleda
commented
- Fix race-condition between data TX watchdog timer and handshakes retries timer
- (at the same time) Fix and unify handshake attempts counter usage: now 0 means no HI in progress. Can use that timer to check if and HIs already sent.
- Do not flood new handhake initiations, if HI is already scheduled by somebody else.
added 2 commits
May 20, 2021 14:15
0 means no HandshakeInitiation (HI) is in progress. Positive number - how many HIs have been already send. This patch also fixes race condition between HI retries and data sent watchdog timer(timersDataSent vs expiredRetransmitHandshake) Signed-off-by: Antanas Gadeikis <antanas.gadeikis@nordsec.com>
Signed-off-by: Antanas Gadeikis <antanas.gadeikis@nordsec.com>
|
Initially those raceconditions were observed on Windows. |
zx2c4-bot
force-pushed
the
master
branch
4 times, most recently
from
eba36c5 to
ffb742d
Compare
zx2c4-bot
force-pushed
the
master
branch
5 times, most recently
from
89a9432 to
b9669b7
Compare
|
This is deliberate I believe. If you don't retry once already in progress, then a single lost packet would prevent a connection from being established. |
zx2c4-bot
force-pushed
the
master
branch
7 times, most recently
from
5ba9663 to
c92064f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.