Skip to content

Conversation

@yeonjin719
Copy link
Member

🚨 관련 이슈

#118

✨ 변경사항

  • 🐞 BugFix Something isn't working
  • 💻 CrossBrowsing Browser compatibility
  • 🌏 Deploy Deploy
  • 🎨 Design Markup & styling
  • 📃 Docs Documentation writing and editing (README.md, etc.)
  • ✨ Feature Feature
  • 🔨 Refactor Code refactoring
  • ⚙️ Setting Development environment setup
  • ✅ Test Test related (storybook, jest, etc.)

✏️ 작업 내용

  • null 예외 처리

😅 미완성 작업

N/A

📢 논의 사항 및 참고 사항

@yeonjin719 yeonjin719 self-assigned this Aug 16, 2025
@yeonjin719 yeonjin719 linked an issue Aug 16, 2025 that may be closed by this pull request
1 task
@coderabbitai
Copy link

coderabbitai bot commented Aug 16, 2025

Caution

Review failed

The pull request is closed.

Summary by CodeRabbit

  • 버그 수정
    • 시간 값이 없거나 잘못된 경우에도 타임라인이 오류 없이 동작하며 기본값 00:00으로 표시됩니다.
    • 정보 섹션에서 값이 없는 항목(예산, 장소, 총 시간, 식사, 키워드)을 자동으로 숨기고, 유효하지 않은 값은 ‘알 수 없음’으로 표시하여 빈 값 노출과 런타임 오류를 방지합니다. 이를 통해 화면이 더 깔끔해지고 안정적으로 표시됩니다.

Walkthrough

Info 컴포넌트는 각 섹션을 전달된 프로퍼티 유무에 따라 조건부 렌더링하도록 변경되었고, 파생 표시값에 null/undefined 가드를 추가했습니다. Timeline 컴포넌트는 시간 문자열이 없을 때도 안전하게 00:00을 표시하도록 로컬 상수를 도입했습니다. 공개 API 변경은 없습니다.

Changes

Cohort / File(s) Change Summary
조건부 렌더링 및 가드 추가
src/components/dateCourse/info.tsx
각 InfoElement를 해당 prop 존재 여부에 따라 조건부 렌더링. 예산/총시간/식사 구성 파생값에 null/undefined 체크 및 기본값 적용(‘알 수 없음’ 등). 키워드/장소도 truthy일 때만 표시. 함수 시그니처 변화 없음.
시간 표시 안전화
src/components/dateCourse/timeline.tsx
time이 null/undefined일 때도 안전하도록 editTime/editMin 로컬 상수 도입(기본 ‘00’). 기존 time.split 사용을 교체해 UI에서 00:00으로 폴백. 퍼블릭 API 변화 없음.

Sequence Diagram(s)

sequenceDiagram
  participant View as View
  participant Info as Info Component
  participant IE as InfoElement

  View->>Info: props(cashTag, locationTag, timeTag, MealTag, keywordTags)
  alt cashTag 존재
    Info->>IE: 예산 섹션 렌더
  end
  alt locationTag 존재
    Info->>IE: 장소 섹션 렌더
  end
  alt timeTag 존재
    Info->>IE: 총 시간 섹션 렌더
  end
  alt MealTag 존재
    Info->>IE: 식사 구성 섹션 렌더
  end
  alt keywordTags 존재
    Info->>IE: 키워드 섹션 렌더
  end
Loading
sequenceDiagram
  participant View as View
  participant TL as Timeline Component

  View->>TL: props(time)
  TL->>TL: editTime = time? split[0] : "00"
  TL->>TL: editMin = time? split[1] : "00"
  TL-->>View: 화면에 editTime:editMin 표시
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 9e05beb and 0ea86d6.

📒 Files selected for processing (2)
  • src/components/dateCourse/info.tsx (1 hunks)
  • src/components/dateCourse/timeline.tsx (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@yeonjin719 yeonjin719 merged commit 69c312d into develop Aug 16, 2025
2 of 3 checks passed
@yeonjin719 yeonjin719 deleted the bugfix/#118 branch August 16, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐞 [BugFix] 데이터 null값처리

2 participants