Namespace Wizchip register defines to avoid name collision with CMSIS HAL code#139
Open
lroop wants to merge 2 commits intoWiznet:masterfrom
Open
Namespace Wizchip register defines to avoid name collision with CMSIS HAL code#139lroop wants to merge 2 commits intoWiznet:masterfrom
lroop wants to merge 2 commits intoWiznet:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few months ago I encountered #137 when interfacing a W5500 to an STM32G4 series microcontroller. This PR renames a bunch of
#definestatement to addWIZCHIP_REG_to them to avoid future collisions with other code.