Skip to content

Update event key to use meetup uid to ensure there are no duplicate events#675

Merged
khairahscorner merged 8 commits intoWomen-Coding-Community:mainfrom
silkenodwell:673-fix-duplicated-events-meetup-import
Mar 9, 2026
Merged

Update event key to use meetup uid to ensure there are no duplicate events#675
khairahscorner merged 8 commits intoWomen-Coding-Community:mainfrom
silkenodwell:673-fix-duplicated-events-meetup-import

Conversation

@silkenodwell
Copy link
Contributor

@silkenodwell silkenodwell commented Mar 3, 2026

Description

#673

Change Type

  • [ x] Bug Fix
  • New Feature
  • Code Refactor
  • Mentor Update
  • Data Update
  • Documentation
  • Other

Related Issue

#673

Pull request checklist

Please check if your PR fulfills the following requirements:

  • [ x] I checked and followed the contributor guide
  • [ x] I have tested my changes locally.
  • [ x] I have added a screenshot from the website after I tested it locally

@silkenodwell silkenodwell requested a review from a team as a code owner March 3, 2026 23:06
khairahscorner
khairahscorner approved these changes Mar 5, 2026
View reviewed changes
Copy link
Contributor

@khairahscorner khairahscorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a merge conflict to resolve but otherwise, LGTM 👍 Thanks

@silkenodwell
Copy link
Contributor Author

silkenodwell commented Mar 5, 2026 •
edited
Loading

@khairahscorner I realised that it might be better to update the Meetup event data even for existing events... otherwise we will not have the latest title and description. For example, if a book club title changes from 'Book Club TBC' to 'Book Club: AI Engineering'.

But since I cannot edit a portion of the yaml file, this would mean rewriting the entire file.

I've pushed these changes in the latest commit, would you be able to review and tell me what you think? I can revert if necessary.

@silkenodwell silkenodwell marked this pull request as draft March 7, 2026 16:40
@silkenodwell silkenodwell marked this pull request as ready for review March 7, 2026 16:40
khairahscorner
khairahscorner requested changes Mar 7, 2026
View reviewed changes
Copy link
Contributor

@khairahscorner khairahscorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments; can you rerun the script again? Maybe it'll fix the duplicate events

silkenodwell and others added 2 commits March 8, 2026 16:20
@silkenodwell @khairahscorner
Update tools/meetup_import.py to remove try-catch block and instead r…
74dd0f4 
…evert to empty string

Co-authored-by: Airah✨ <airahyusuff@gmail.com>
@nodwells
Remove events from events.yml with title-date uid duplicates
091d52b 
Running the script again `sh meetup_event.sh` now does not generate any further duplicates
@silkenodwell
Copy link
Contributor Author

silkenodwell commented Mar 8, 2026

Left some comments; can you rerun the script again? Maybe it'll fix the duplicate events

I've fixed the duplicate events, and running the script again doesn't generate any new ones. Sorry about this.

@khairahscorner khairahscorner merged commit 4b16946 into Women-Coding-Community:main Mar 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khairahscorner khairahscorner khairahscorner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@silkenodwell @khairahscorner @nodwells