test: Become a mentee Section #143#202
Open
joanaBrit wants to merge 8 commits intoWomen-Coding-Community:mainfrom
Open
test: Become a mentee Section #143#202joanaBrit wants to merge 8 commits intoWomen-Coding-Community:mainfrom
joanaBrit wants to merge 8 commits intoWomen-Coding-Community:mainfrom
Conversation
joanaBrit
requested review from
a team and
womencodingcommunity
as code owners
joanaBrit
requested review from
Lize101,
Madele-theron,
MitaliShah and
daiterranova
|
@joanaBrit is attempting to deploy a commit to the Women Coding Community's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Contributor
Author
|
Hi @nora-weisser, I’ve made all the requested changes and pushed the updates. Please let me know if there’s anything else you’d like me to adjust. I don't know why the test is failing. |
Comment on lines
+6
to
+37
| test('Validate "Become a Mentee" section and Find a Mentor button', async ({ | ||
| page, | ||
| }) => { | ||
| // Navigate to Mentorship page | ||
| await page.goto('/mentorship'); | ||
|
|
||
| // "Become a Mentee" section | ||
| const { sectionTitle, description, menteeListItems } = new MentorshipPage( | ||
| page, | ||
| ); | ||
|
|
||
| await expect(sectionTitle).toBeVisible(); | ||
| await expect(description).toBeVisible(); | ||
|
|
||
| // List items | ||
| const items = [ | ||
| 'Want to start a career in software engineering', | ||
| 'Want to find a better job', | ||
| 'Want to be promoted at work', | ||
| 'Want to apply for a leadership position', | ||
| 'Need support in advancing your career', | ||
| ]; | ||
|
|
||
| await expect(menteeListItems).toHaveText(items); | ||
|
|
||
| // Validate "Find a mentor" button | ||
| const { findMentorButton } = new HomePage(page); | ||
| await findMentorButton.click(); | ||
|
|
||
| // Verify redirection | ||
| await expect(page).toHaveURL(/\/mentorship\/mentors/); | ||
| }); |
Contributor
There was a problem hiding this comment.
Suggested change
| test('Validate "Become a Mentee" section and Find a Mentor button', async ({ | |
| page, | |
| }) => { | |
| // Navigate to Mentorship page | |
| await page.goto('/mentorship'); | |
| // "Become a Mentee" section | |
| const { sectionTitle, description, menteeListItems } = new MentorshipPage( | |
| page, | |
| ); | |
| await expect(sectionTitle).toBeVisible(); | |
| await expect(description).toBeVisible(); | |
| // List items | |
| const items = [ | |
| 'Want to start a career in software engineering', | |
| 'Want to find a better job', | |
| 'Want to be promoted at work', | |
| 'Want to apply for a leadership position', | |
| 'Need support in advancing your career', | |
| ]; | |
| await expect(menteeListItems).toHaveText(items); | |
| // Validate "Find a mentor" button | |
| const { findMentorButton } = new HomePage(page); | |
| await findMentorButton.click(); | |
| // Verify redirection | |
| await expect(page).toHaveURL(/\/mentorship\/mentors/); | |
| }); | |
| test('Validate "Become a Mentee" section and Find a Mentor button', async ({ | |
| page, mentorshipPage, homePage | |
| }) => { | |
| // Navigate to Mentorship page | |
| await page.goto('/mentorship'); | |
| await expect(mentorshipPage.sectionTitle).toBeVisible(); | |
| await expect(mentorshipPage.description).toBeVisible(); | |
| // List items | |
| const items = [ | |
| 'Want to start a career in software engineering', | |
| 'Want to find a better job', | |
| 'Want to be promoted at work', | |
| 'Want to apply for a leadership position', | |
| 'Need support in advancing your career', | |
| ]; | |
| await expect(mentorshipPage.menteeListItems).toHaveText(items); | |
| await homePage.findMentorButton.click(); | |
| await expect(page).toHaveURL(/\/mentorship\/mentors/); | |
| }); |
Since homePage and mentorshipPage are fixtures, they can be called directly in the test case :)
Contributor
There was a problem hiding this comment.
Could you please try this approach?
| buttonText={'Join as a mentor'} | ||
| ></MentorBecomeCard> | ||
| <MentorBecomeCard | ||
| listTestId="mentee-card" |
Contributor
There was a problem hiding this comment.
Suggested change
| listTestId="mentee-card" | |
| listTestId="become-mentee-card" |
Maybe better to call it become-mentee-card? :)
| level: 5, | ||
| name: /You should become a mentee if you:/i, | ||
| }); | ||
| this.menteeListItems = page.locator('ol[data-testid="mentee-card"] > li'); |
Contributor
There was a problem hiding this comment.
In order to locate by data-testid, it is enough to call this.page.getByTestId(<data-testid>).
Contributor
Great job! I left a few more comments :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Playwright tests for the "Become a mentee Section" page
Type
Related Issue
#143
Screenshots
Testing
Playwright test
Pull request checklist
Please check if your PR fulfills the following requirements: