Draft
Conversation
This reverts commit 292b5d8.
Contributor
|
I think that before solving the problem with how to display positive results (scorecards/flags), there needs to be a discussion and decision about which checks to show results for. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE.
We are currently printing test results in natural language to the respective action logs. In the future, it will make sense to share the theme results in a format that is easier to consume.
The Idea:
If we could create a scorecard, similar to lighthouse, we will be able to use that information to help authors and the theme directory.
This PR adds logic that prints error tests to a log called
theme-scorecard.jsonin json format.Example :
It isn't very sophisticated at this point and only prints errors as a
0score. It's a bit tricky because we currently only capture errors & warnings, and therefore the absence of a test result would suggest that it has passed. We could capture passes in theui-checkbut I don't think that will work with thetheme-checkresults.