Skip to content

Update: Update Label to Administration Color Scheme from Admin Color Scheme #8449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Update: Update Label to Administration Color Scheme from Admin Color Scheme #8449

wants to merge 5 commits into from

Conversation

Debarghya-Banerjee
Copy link

@Debarghya-Banerjee Debarghya-Banerjee commented Mar 4, 2025 •
edited
Loading

Trac Ticket: Core-63048

Overview

This PR updates the label from Admin Color Scheme to Administration Color Scheme for better clarity and consistency across the WordPress admin interface.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props debarghyabanerjee, pedrofigueroa1989, audrasjb.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

mardelnet
mardelnet reviewed Jun 5, 2025
View reviewed changes
src/wp-admin/includes/misc.php
@@ -1025,7 +1025,7 @@ function admin_color_scheme_picker( $user_id ) {
<legend class="screen-reader-text"><span>
<?php
/* translators: Hidden accessibility text. */
_e( 'Admin Color Scheme' );
_e( 'Administration Color Scheme' );
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also change the comment on line 991 to say Displays the default administration color scheme picker (Used in user-edit.php). instead of Displays the default admin color scheme picker (Used in user-edit.php).?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I agree, @mardelnet are you able to send a new PR for this? Or find anyone able to do so?
(you are at WCEU contributor day I presume?)

Copy link
Author

@Debarghya-Banerjee Debarghya-Banerjee Jun 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @audrasjb , I have made the update to the comment.

Cc: @mardelnet

audrasjb
audrasjb requested changes Jun 5, 2025
View reviewed changes
src/wp-admin/includes/misc.php
@@ -1025,7 +1025,7 @@ function admin_color_scheme_picker( $user_id ) {
<legend class="screen-reader-text"><span>
<?php
/* translators: Hidden accessibility text. */
_e( 'Admin Color Scheme' );
_e( 'Administration Color Scheme' );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I agree, @mardelnet are you able to send a new PR for this? Or find anyone able to do so?
(you are at WCEU contributor day I presume?)

mardelnet
mardelnet approved these changes Jun 5, 2025
View reviewed changes
Copy link

@mardelnet mardelnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mardelnet
Copy link

This is a bit picky, but the PR title and description still mention Dashboard instead of Administration.
Can we change it to keep everything consistent?

@Debarghya-Banerjee Debarghya-Banerjee changed the title Update: Update Label to Dashboard Color Scheme from Admin Color Scheme Update: Update Label to Administration Color Scheme from Admin Color Scheme Jun 5, 2025
@Debarghya-Banerjee
Copy link
Author

@mardelnet Updated the Title and Description.

@audrasjb
Copy link
Contributor

audrasjb commented Jun 5, 2025

Perfect, thanks for the update.
@mardelnet no strong need to update the PR title/desc, I'll commit this today anyway :)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2025

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 60284
GitHub commit: aa1f5ef

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions bot closed this Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@audrasjb audrasjb audrasjb requested changes

@mardelnet mardelnet mardelnet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Debarghya-Banerjee @mardelnet @audrasjb