[Blueprints] Don't treat extra output during plugin activation as a failure #2904
+89
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plugin activation step choked when PHP emitted extra output during the verification run, mis-parsing the active plugin list and throwing even though activation succeeded. I now wrap a second marker-delimited status check when unexpected output appears and added a regression test where activation and shutdown hooks echo text, confirming we log the noise and continue.
adamziel
added
[Type] Enhancement
Updated the activation response handling to check for JSON success output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some WordPress plugins emit output during activation. Before this PR, Playground treated that as an activation error. But that's not right, the plugin may still get activated. This PR checks in with WordPress whether or not the plugin is activated after we're tried to activate it. If it is, that's our success.
Testing Instructions (or ideally a Blueprint)
CI, this PR ships a new test.