Fix trace header injection for calls using URL-first signature #438
+91
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgerbe
requested review from
echetzakis,
klesgidis,
kzacharakis,
nikosd23 and
stavros-wb
as code owners
klesgidis
approved these changes
Jan 23, 2026
iliasbibas
approved these changes
Jan 23, 2026
Nikoklis
reviewed
Jan 26, 2026
Nikoklis
approved these changes
Jan 26, 2026
jgerbe
force-pushed
the
bugfix/http-request-signature
branch
from
36c6781 to
5e84d39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix trace header injection for http.request() calls using URL-first signature (e.g., Google API). The proxy handler now correctly detects when the first argument is a URL string/object and injects headers into the options object at the correct position.
https://nodejs.org/api/http.html#httprequestoptions-callback
https://nodejs.org/api/http.html#httprequesturl-options-callback