-
Notifications
You must be signed in to change notification settings - Fork 6
recover avoid msft churn #1012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rc-v0.5.17
Are you sure you want to change the base?
recover avoid msft churn #1012
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Switches sample date generation from a monthly first-of-month time_static resource (built from a dynamic timestamp expression that caused churn) to a long-lived time_rotating resource to reduce unnecessary Terraform plan diffs. This introduces a controlled annual rotation and aligns with the stated breaking change requiring Terraform 1.7.x.
- Replace time_static month_start with time_rotating example_timestamp (rotation_days = 365)
- Update module input example_api_calls_sample_date to use the new rotating resource ID
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
WARNING: breaking change, needs to wait for next version that permits breaking changes (target 0.6.x)
Fixes
time_rotatinginstead oftime_staticwrapping a function call, as truncation done in the expression isn't sufficient enough to stop Terraform from thinking there's a changeChange implications