Skip to content

Conversation

@eschultink
Copy link
Member

Fixes

  • path problem when invoking from gh action workflow

Change implications

  • dependencies added/changed? no
  • something important to note in future release notes? no

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a path handling issue in the Maven artifact publishing script to ensure proper operation when invoked from GitHub Actions workflow. The script now normalizes repository paths and updates workflow references.

Changes:

  • Added logic to append a trailing slash to PATH_TO_REPO when missing
  • Corrected workflow filename reference in warning message

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

fi

# if PATH_TO_REPO is not blank, but does not end with a slash, add one
if [[ "$PATH_TO_REPO" != "/"* ]]; then
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition checks if the path does NOT start with a slash (checking for absolute paths), but the comment states it checks if the path does not END with a slash. The logic should be if [[ \"$PATH_TO_REPO\" != */ ]]; then to append a trailing slash when missing, which matches both the comment's intent and the fix described in the PR.

Suggested change
if [[ "$PATH_TO_REPO" != "/"* ]]; then
if [[ "$PATH_TO_REPO" != */ ]]; then

Copilot uses AI. Check for mistakes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without trying it, this suggestion seems correct to me @eschultink

Base automatically changed from rc-v0.5.16 to main January 29, 2026 18:27
@eschultink eschultink changed the base branch from main to rc-v0.5.17 January 29, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants