Merged ADC-API with the fix #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged ADC-API changes Modified the "read_single_sample" function to assign channel as u32 to avoid an unnecessary panic. Signed-off-by: LithTheFox <thelittrion@gmail.com>
Reordered arguments so that sample is first and can be read by listener.get() Signed-off-by: LithTheFox thelittrion@gmail.com
(this commit is mostly to fix the sign off error) Signed-off-by: Pavel Denis-Iulian <denispavel94@gmail.com>
Needed github details can't take real name and adress Signed-off-by: LithTheFox <thelittrion@gmail.com>
Signed-off-by: LithTheFox thelittrion@gmail.com
The original listener test was asserting only the first argument of the .schedule_upcall which is not the sample. Modifying the function to set sample as the first argument conflicts with the assessments in /peripherals/adc/src/test.rs The test was modified to check for the third argument which was the where the sample should be checked for and now the test asserts the value correctly. Signed-off-by: LithTheFox thelittrion@gmail.com
Open
Unnecessary channel cast already usize Signed-off-by: LithTheFox thelittrion@gmail.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original listener test was asserting only the first argument of the .schedule_upcall which is not the sample.
Modifying the function to set sample as the first argument conflicts with the assessments in /peripherals/adc/src/test.rs
The test was modified to check for the third argument which was the where the sample should be checked for and now the test asserts the value correctly.
Signed-off-by: LithTheFox denispavel94@gmail.com