Implemented ALINES() using Regex to support unlimited separators #1775
+211
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements the ALINES() function for Visual FoxPro compatibility, using regular expressions to support an unlimited number of separators (surpassing VFP's limit of 23). The implementation handles all flag combinations including trimming, empty line handling, case-insensitive parsing, and separator inclusion.
- Implemented ALINES() function with regex-based parsing in ArrayFunctions.prg
- Added flag constants (ALINES_TRIM, ALINES_INCLUDE_LAST, ALINES_NO_EMPTY, ALINES_CASE_IGNORE, ALINES_INCLUDE_SEP) in Defines.prg
- Removed ALINES stub from ToDo-A.prg as it's now implemented
- Added comprehensive test suite covering most flag combinations
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/Runtime/XSharp.VFP/ArrayFunctions.prg | Implements the ALINES() function using Regex.Split with support for multiple separators and all VFP flags, and adds necessary using statements for System.Text.RegularExpressions, System.Collections.Generic, and System.Text |
| src/Runtime/XSharp.VFP/Defines.prg | Adds five flag constants for ALINES() function behavior control |
| src/Runtime/XSharp.VFP/ToDo-A.prg | Removes the ALINES function stub as it has been implemented |
| src/Runtime/XSharp.VFP.Tests/FoxArraytests.prg | Adds ALinesTests class with six test methods covering basic parsing, custom separators, multiple separators, and various flag behaviors |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RobertvanderHulst
approved these changes
Dec 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented ALINES() using Regex to support unlimited separators (surpassing VFP's limit of 23). Handles all flags including Case Insensitive and Include Separators.
Merry Christmas team!🥂