Dev #1777
Closed
Dev #1777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds to be supported for Clipper Calling Convention. We now generate the error and remove the error in case of a Clipper Calling Convention method with byref parameters
…nto somevar[1,2]
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements several compiler fixes and updates to the Runtime and Visual Studio integration, primarily adding support for the RECORD keyword and fixing various parsing and diagnostic issues in the XSharp compiler.
Key changes:
- Added support for the RECORD keyword as a type definition construct (similar to CLASS/STRUCTURE)
- Changed PSZ conversion operators from IMPLICIT to EXPLICIT for INT, INT64, and DWORD types to prevent unintended implicit conversions
- Fixed parsing issues with type check expressions and pattern matching in various contexts
- Added error suppression for Clipper calling convention methods when passing properties by reference
Reviewed changes
Copilot reviewed 10 out of 16 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| XsParser.prg | Added RECORD keyword support for defining classes and structures with proper entity kind detection |
| XTokenType.prg | Added RECORD and PP_nullable token types to the enum |
| FormattingRules.txt | Added RECORD/END RECORD formatting rules |
| PSZ.prg | Changed conversion operators to EXPLICIT for numeric types and fixed indentation throughout the file |
| Binder.ValueChecks.cs | Removed trailing whitespace from comments |
| XSharpTreeTransformationCore.cs | Fixed type check expression parsing and added NOT pattern support; fixed indentation |
| XSharp.g4 | Added FoxPro-specific bracketed argument list handling for multi-dimensional array syntax |
| DiagnosticsPass.cs | Added bounds check before accessing node.Arguments array; fixed spacing |
| LocalRewriter_XBase.cs | Fixed spacing around method arguments and operators |
| XSharpListener.cs | Updated auto-generated file path comment |
| XSharpBaseListener.cs | Updated auto-generated file path comment |
| Binder_Invocation.cs | Added logic to suppress ERR_RefProperty errors for Clipper calling convention methods |
| Binder_Expressions.cs | Fixed indentation and spacing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/Compiler/src/Compiler/XSharpCodeAnalysis/Binder/Binder_Invocation.cs
Show resolved
Hide resolved
src/Compiler/src/Compiler/XSharpCodeAnalysis/Lowering/DiagnosticsPass.cs
Show resolved
Hide resolved
src/Compiler/src/Compiler/XSharpCodeAnalysis/Parser/XSharpTreeTransformationCore.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several compiler fixes and some fixes to the Runtime and VsIntegration