-
Notifications
You must be signed in to change notification settings - Fork 12
Fix typos, update testing link, and upgrade to Ruby 4.0.1 #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Update GitHub Actions workflow to use Ruby 4.0.1 - Update README Docker example to use Ruby 4.0.1 - Replace deprecated File.exists? with File.exist? in svgconvert plugin This addresses Ruby version inconsistencies and prepares for Ruby 4 compatibility.
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThese changes update Ruby and Docker image versions, replace a deprecated API call with its modern equivalent, correct several typographical errors in documentation, and replace broken testing version links with a generic testing page. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (3 warnings)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Ruby 4.0.1 requires updated dependencies (ffi gem doesn't support Ruby 4 yet). Using Ruby 3.4.8 which is compatible with current Gemfile.lock while still upgrading from 3.4.7.
Jekyll is already at latest version 4.4.1. Updated constraint for cleaner syntax while maintaining same version range.
The constraint change caused bundler to require Gemfile.lock update in frozen mode. Since ~> 4.4.0 and ~> 4.4 are functionally equivalent and Jekyll is already at latest 4.4.1, reverting to original.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@Gemfile`:
- Line 10: The Gemfile requires jekyll "~> 4.4" but Gemfile.lock pins jekyll to
a narrower "~> 4.4.0", causing Bundler CI to fail; update the lockfile by
running `bundle lock --update jekyll` (or `bundle install`) locally to
regenerate Gemfile.lock to match the Gemfile constraint, then commit the updated
Gemfile.lock so the CI bundler-cache check succeeds.
This PR fixes several issues found in the repository:
Fixes #61
Summary by CodeRabbit
Bug Fixes
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.