Skip to content

Conversation

@lordfolken
Copy link
Member

@lordfolken lordfolken commented Jan 25, 2026

This PR fixes several issues found in the repository:

Fixes #61

Summary by CodeRabbit

  • Bug Fixes

    • Fixed deprecated Ruby method call to align with current standards.
    • Corrected multiple typographical errors in documentation and release notes.
  • Documentation

    • Updated Docker image version requirement to Ruby 3.4.8.
    • Enhanced testing download link to support all platforms.
    • Improved build workflow with updated tool versions.

✏️ Tip: You can customize this high-level summary in your review settings.

Philipp Wollschlegel added 3 commits January 25, 2026 19:48
…testing/

Fixes issue #61 - replaces broken Play Store and nightly_builds links
with the correct testing build URL.
- Update GitHub Actions workflow to use Ruby 4.0.1
- Update README Docker example to use Ruby 4.0.1
- Replace deprecated File.exists? with File.exist? in svgconvert plugin

This addresses Ruby version inconsistencies and prepares for Ruby 4 compatibility.
@coderabbitai
Copy link

coderabbitai bot commented Jan 25, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

These changes update Ruby and Docker image versions, replace a deprecated API call with its modern equivalent, correct several typographical errors in documentation, and replace broken testing version links with a generic testing page.

Changes

Cohort / File(s) Summary
Version & Dependency Updates
\.github/workflows/website-deploy.yml, README.md
Updated Ruby version from 3.4.7 to 3.4.8, checkout action version, and Docker image tag from ruby:3.3.5 to ruby:3.4.8
Code Modernization
_plugins/svgconvert.rb
Replaced deprecated File.exists? with File.exist? in write path check; no logic changes
Content & Documentation
_posts/2024-09-02-xcsoar-7-dot-43-released.md, develop/index.md
Fixed typo "CRICITAL" → "CRITICAL" in blog post; corrected typos "relase" → "release" in README; replaced broken Android-specific testing links with generic testing page reference

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Whisker-twitching updates bright,
Versions bumped and links made right,
Deprecated calls now cleaned away,
Typos fixed with hopping cheer today! 🥕✨

🚥 Pre-merge checks | ✅ 2 | ❌ 3
❌ Failed checks (3 warnings)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title claims 'upgrade to Ruby 4.0.1' but the actual changes show downgrade to Ruby 3.4.8 due to dependency incompatibility, making the title misleading. Correct the title to accurately reflect the actual changes: 'Fix typos, update testing link, upgrade Ruby to 3.4.8, and replace deprecated File.exists?'
Out of Scope Changes check ⚠️ Warning The PR includes several out-of-scope changes beyond Issue #61: typo fixes in unrelated files, Ruby version updates/downgrades, Jekyll dependency version adjustments, and deprecated API replacements. Consider separating out-of-scope changes (typos, Ruby/Jekyll updates, API modernization) into a separate PR focused on a single objective, or document why bundled changes are necessary.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed The pull request successfully addresses Issue #61 by replacing the broken Android Play Store link and nightly_builds URL with a functional testing version link on the develop page.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Philipp Wollschlegel added 4 commits January 25, 2026 19:52
Ruby 4.0.1 requires updated dependencies (ffi gem doesn't support Ruby 4 yet).
Using Ruby 3.4.8 which is compatible with current Gemfile.lock while still
upgrading from 3.4.7.
Jekyll is already at latest version 4.4.1. Updated constraint
for cleaner syntax while maintaining same version range.
The constraint change caused bundler to require Gemfile.lock update
in frozen mode. Since ~> 4.4.0 and ~> 4.4 are functionally equivalent
and Jekyll is already at latest 4.4.1, reverting to original.
- Update nanoc from 4.14.3 to 4.14.6 (performance improvements)
- Update related dependencies: addressable, concurrent-ruby, zeitwerk
- Update actions/checkout to latest v6 commit (8e8c483)

Addresses PRs #152 and #153
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@Gemfile`:
- Line 10: The Gemfile requires jekyll "~> 4.4" but Gemfile.lock pins jekyll to
a narrower "~> 4.4.0", causing Bundler CI to fail; update the lockfile by
running `bundle lock --update jekyll` (or `bundle install`) locally to
regenerate Gemfile.lock to match the Gemfile constraint, then commit the updated
Gemfile.lock so the CI bundler-cache check succeeds.

@lordfolken lordfolken merged commit b4ed336 into master Jan 25, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Links are outdated for XCSoar-testing (page not found) and nightly-build (404) version

1 participant