Change data_kind from 'individual_electrons' to 'extracted_electrons' #362
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced an inconsistency in the data kinds in the #264 PR.
We have that PropagatedElectrons and Extracted electrons had the same data kind, but different number of rows (because in the second one we kept only the extracted electrons, roughly 50% of the total propagated ones). This was not really showing up anywhere, because the PropagatedElectrons has as a unique parent that is ExtractedElectrons, and no other plugins ever tried to put the two together.
What is proposed here is to just introduce a new data kind for ExtractedElectrons (and delayed ones).
Other option I can think of is to just merge ElectronPropagation and ElectronExtraction and just never save the details of positions of the electrons that won't be extracted.
Plugin attribute standardization:
data_kindfromindividual_electronstoextracted_electronsin bothElectronExtractionandExtractedElectronsMergerclasses to ensure consistent naming for extracted electron data. [1] [2]data_kindfromdelayed_individual_electronstodelayed_extracted_electronsinDelayedElectronsExtractionfor clearer distinction of delayed extracted electrons.Version updates:
ElectronExtractionto0.4.0,DelayedElectronsExtractionto0.0.3, andExtractedElectronsMergerto0.0.3. [1] [2] [3]