Skip to content

Conversation

@cfuselli
Copy link
Member

@cfuselli cfuselli commented Nov 28, 2025

We introduced an inconsistency in the data kinds in the #264 PR.
We have that PropagatedElectrons and Extracted electrons had the same data kind, but different number of rows (because in the second one we kept only the extracted electrons, roughly 50% of the total propagated ones). This was not really showing up anywhere, because the PropagatedElectrons has as a unique parent that is ExtractedElectrons, and no other plugins ever tried to put the two together.

What is proposed here is to just introduce a new data kind for ExtractedElectrons (and delayed ones).
Other option I can think of is to just merge ElectronPropagation and ElectronExtraction and just never save the details of positions of the electrons that won't be extracted.

Plugin attribute standardization:

  • Changed data_kind from individual_electrons to extracted_electrons in both ElectronExtraction and ExtractedElectronsMerger classes to ensure consistent naming for extracted electron data. [1] [2]
  • Updated data_kind from delayed_individual_electrons to delayed_extracted_electrons in DelayedElectronsExtraction for clearer distinction of delayed extracted electrons.

Version updates:

  • Incremented version numbers in all affected plugins to reflect these attribute changes: ElectronExtraction to 0.4.0, DelayedElectronsExtraction to 0.0.3, and ExtractedElectronsMerger to 0.0.3. [1] [2] [3]

@cfuselli cfuselli requested a review from HenningSE November 28, 2025 11:20
@cfuselli cfuselli marked this pull request as ready for review November 28, 2025 11:20
@cfuselli cfuselli marked this pull request as draft November 28, 2025 11:29
@cfuselli
Copy link
Member Author

Missing changing the types in all the compute functions still

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants