Tob audit fix#23
Merged
jonathanMweiss merged 4 commits intoschnorrfrom Sep 18, 2025
Merged
Conversation
jonathanMweiss
commented
Sep 17, 2025
- DKG generates configs with new partyID: pid = hash of public key pem.
- updated the testing configs accordingly.
- DKG fatal error instead of a log for server setup issues.
- removed warning spam in tss server logs.
There was a problem hiding this comment.
Pull Request Overview
This PR implements security audit fixes for the TSS (Threshold Signature Scheme) DKG (Distributed Key Generation) system. The changes include switching from PEM public keys to SHA-512 hashes as party IDs for improved security and updating error handling to use fatal logging instead of warnings.
- Changes party ID generation from using PEM public keys directly to SHA-512 hashes of the PEM keys
- Updates DKG server error handling to use fatal logging for critical failures
- Reduces log spam by converting warning messages to debug level or removing redundant checks
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| node/pkg/tss/internal/cmd/dkg/server.go | Updates error handling to use Fatal instead of Error logging and improves DKG session logging |
| node/pkg/tss/internal/cmd/common.go | Implements SHA-512 hashing for party ID generation and updates identity sorting logic |
| node/pkg/tss/implementation_test.go | Updates test cases to use KeyPEM instead of party ID for leader identity references |
| node/pkg/tss/identity.go | Adds new mapping for party ID to index lookups and error handling |
| node/pkg/tss/comm/server.go | Reduces log spam by converting warning to debug level and removing redundant context checks |
| node/pkg/tss/cnfgs.go | Adds party ID to index mapping initialization |
| Guardian configuration files | Updates all test configuration files with new SHA-512 based party IDs and TSS secrets |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
yossigi
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.