Skip to content

Tob audit fix#23

Merged
jonathanMweiss merged 4 commits intoschnorrfrom
tob-audit-fix
Sep 18, 2025
Merged

Tob audit fix#23
jonathanMweiss merged 4 commits intoschnorrfrom
tob-audit-fix

Conversation

@jonathanMweiss
Copy link
Copy Markdown

  • DKG generates configs with new partyID: pid = hash of public key pem.
    • updated the testing configs accordingly.
  • DKG fatal error instead of a log for server setup issues.
  • removed warning spam in tss server logs.

@jonathanMweiss jonathanMweiss self-assigned this Sep 17, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements security audit fixes for the TSS (Threshold Signature Scheme) DKG (Distributed Key Generation) system. The changes include switching from PEM public keys to SHA-512 hashes as party IDs for improved security and updating error handling to use fatal logging instead of warnings.

  • Changes party ID generation from using PEM public keys directly to SHA-512 hashes of the PEM keys
  • Updates DKG server error handling to use fatal logging for critical failures
  • Reduces log spam by converting warning messages to debug level or removing redundant checks

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
node/pkg/tss/internal/cmd/dkg/server.go Updates error handling to use Fatal instead of Error logging and improves DKG session logging
node/pkg/tss/internal/cmd/common.go Implements SHA-512 hashing for party ID generation and updates identity sorting logic
node/pkg/tss/implementation_test.go Updates test cases to use KeyPEM instead of party ID for leader identity references
node/pkg/tss/identity.go Adds new mapping for party ID to index lookups and error handling
node/pkg/tss/comm/server.go Reduces log spam by converting warning to debug level and removing redundant context checks
node/pkg/tss/cnfgs.go Adds party ID to index mapping initialization
Guardian configuration files Updates all test configuration files with new SHA-512 based party IDs and TSS secrets

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread node/pkg/tss/internal/cmd/common.go Outdated
Comment thread node/pkg/tss/internal/cmd/dkg/server.go Outdated
Comment thread node/pkg/tss/implementation_test.go Outdated
@jonathanMweiss jonathanMweiss merged commit c4489de into schnorr Sep 18, 2025
22 of 27 checks passed
@jonathanMweiss jonathanMweiss deleted the tob-audit-fix branch September 18, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants