CombatTracker, ChatCard, Fear Roll and localization fixes

[sasquach45932]

Thanks for pt-br transaltion to @nafeels !

[sasquach45932]

[sasquach45932]

Item macro

PrePass	PostPass	Description
preRollAttack	postRollAttack	Weapon
preRollTalent	postRollTalent	Talent/Special Attack
preRollSpell	postRollSpell	Spell
preRollItem	postRollItem	Inventory Item/Trait/Special Action, End Of The Round (*)
preRollItem	postRollItem	End Of The Round (**)

Global parameters: item, speaker, actor, token, character

Pass specific parameters:

Pass	Parameters
preRollAttack	attackAttribute, defenseAttribute, targetActorUuid
postRollTalent	attackRoll, targetNumber, successfullHit ,plus20, targetActorUuid
preRollTalent	targetActorUuid (*)
postRollTalent	attackRoll, targetNumber, successfullHit ,plus20, targetActorUuid
preRollSpell	attackAttribute, defenseAttribute, targetActorUuid
postRollSpell	attackRoll, targetNumber, successfullHit ,plus20, targetActorUuid
preRollItem	targetActorUuid (*)
postRollItem	targetActorUuid (*)
preRollItem	attackAttribute, defenseAttribute, targetActorUuid (*)
postRollItem	attackRoll, targetNumber, successfullHit ,plus20, targetActorUuid (**)

(*) - Does not have attack attribute
(**) - Has attack attribute

Example Weapon macro.

In case of successful hit, it applies the Blinded affliction on the target for 1 round. If the total of the attack roll was 20 or higher and exceeds the score of the attribute or characteristic by 5 or more, the Blinded affliction duration is 3 rounds.

if (args.pass === 'postRollAttack' && args.successfullHit) {
    const targetActor = fromUuidSync(args.targetActorUuid)
    const blindedEffect = foundry.utils.deepClone(CONFIG.statusEffects.find(e => e.id === 'blinded'))
    blindedEffect['statuses'] = blindedEffect.id
    blindedEffect.duration.rounds = args.plus20 ? 3 : 1

    await ActiveEffect.create(blindedEffect, {
        parent: targetActor,
    })
}

[juanferrer]

Added a few questions/suggestions.

[juanferrer]

Maybe should change the name to improve clarity, as it's building the localization string and handling special cases.

[juanferrer]

Maybe we should get the value once to avoid querying the settings so many times.

const itemMacroEnabled = game.settings.get('demonlord', 'enableItemMacro')

and reuse

[juanferrer]

From what I understand the code, it's basically the following:

• If we're in traitMode2025, it only matters if it's horrifying
• Otherwise, we add the relevant string for frightening/horrifying

Nested ternary operators get too complex too quickly. It can be simplified like this:

let creatureType = ''
const isFrightening = defender?.system.frightening
const isHorrifying = defender?.system.horrifying
const isTraitMode2025 = game.settings.get('demonlord', 'optionalRuleTraitMode2025')

if (isHorrifying && isTraitMode2025) {
  creatureType = game.i18n.localize('DL.CreatureHorrifying')
} else if (isFrightening || isHorrifying) {
  creatureType = isHorrifying ? game.i18n.localize('DL.CreatureHorrifying') : game.i18n.localize('DL.CreatureFrightening')
}

I removed the frightening AND horrifying case, as a creature can't be frightening and horrifying, the strongest state wins (i.e. horrifying).

[juanferrer]

Looks good!