fix: goroutine WaitGroup race in test#289
Merged
gongna-au merged 1 commit intoXiaoMi:mainfrom Sep 8, 2025
Merged
Conversation
Collaborator
|
你好 @l2dy👋 非常感谢你提交这个 MR 来修复该问题！👍 我仔细看了一下，修改完全正确，这避免了竞争。这对社区非常有帮助！ 再次感谢你的细心和贡献！欢迎继续为社区做贡献！ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's unlikely to get a race condition given the
time.Sleep(time.Millisecond * 50)call beforeg.Wait(), but nonetheless this should be fixed.