fix(core): A couple plugin manager related fixes. #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PluginManager: * Strip suffixes of semantic versioned plugins (ie. `-beta`) using a regex. It doesn't contribute to the actual versioning. The built-in version parser does not handle this, so just strip it. In PluginList: * Wrap the building of the plugin list UI in the TableLayoutPanel with SuspendLayout() / ResumeLayout() to improve performance. * Avoid random layout engine failures (ie. index-out-of-bounds and null dereference errors) resulting from lack of thread safety in the layout engine caused by running multiple threads which manipulate the plugin list. I was able to consistently reproduce this with 4 plugins triggering an update to the plugin list before my fix, and cannot trigger it now. See screenshot for visual of broken UI that results. Instead of firing the update-check tasks immediately during main layout of the plugin list, collect the tasks **un-started** and run them one at a time on a separate non-blocking task after completing the layout of the plugin list UI. These update check tasks may take slightly longer due to running serially, it should not be noticeable because they should not block the main thread.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PluginManager:
-beta) using a regex. It doesn't contribute to the actual versioning. The built-in version parser does not handle this, so just strip it.In PluginList:
Note the misplaced update label at the top of the PluginList:
