✨ Add "View details" dialog for long JupyterLab notifications#460
✨ Add "View details" dialog for long JupyterLab notifications#460rabea-al wants to merge 6 commits intoXpressAI:masterfrom
Conversation
MFA-X-AI
left a comment
There was a problem hiding this comment.
Thanks for the PR, it works very well!
Slightly related, I think I missed this in the previous PR, I noticed for components with libraries that exist in our manifest, the message is formatted like this:
You need to install the "xai_components/xai_sqlite" library to use "SqliteFetchAll" component.
Could you update it so it shows xai_sqlite or sqlite? Thanks!
MFA-X-AI
left a comment
There was a problem hiding this comment.
One additional thing I'd like you to do - currently once the longer preview is active, pressing the copy button dismisses the popup. Ideally it should keep it and either change the icon to "Copied!" or fire a notification.
MFA-X-AI
left a comment
There was a problem hiding this comment.
Thanks for the update. Unfortunately I don't see copy error button here.
If I check F12, it says:
Error reloading component from path: xai_components/xai_utils/utils.py. Error: Cannot read properties of undefined (reading 'class')
Aside from that, the implementation does look much more complicated than I thought for a small gain. I did check the previous issue, and someone did raise it before but it hasn't been reponded. Since it's not natively supported in Jupyterlab, let's go with a simple notification for the copied instead.
|
The copy button is actually located at the top-right corner of the dialog. |
…tails dialog" This reverts commit 9a353a4.
Description
This PR enhances the notification system in Xircuits by adding a "View details" button to all JupyterLab notifications that exceed 140 characters. Clicking the button opens a dialog displaying the full message with an option to copy it to the clipboard.
Pull Request Type
Type of Change
Tests
Notification.info,Notification.error, etc.) are all augmented globally.Tested on? Specify Version.