Skip to content

Sparse test #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
XucSh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Sparse test #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions mooncake-integration/store/store_py.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ struct PyTensorInfo {
TensorMetadata metadata;

// Check validity
bool valid() const { return tensor_size > 0; }
bool valid() const { return true; }
};

PyTensorInfo extract_tensor_info(const py::object &tensor,
Expand Down Expand Up @@ -91,7 +91,7 @@ pybind11::object buffer_to_tensor(BufferHandle *buffer_handle, char *usr_buffer,
char *exported_data;
if (take_ownership) {
total_length = buffer_handle->size();
if (total_length <= sizeof(TensorMetadata)) {
if (total_length < sizeof(TensorMetadata)) {
LOG(ERROR) << "Invalid data format: insufficient data for metadata";
return pybind11::none();
}
Expand All @@ -110,7 +110,7 @@ pybind11::object buffer_to_tensor(BufferHandle *buffer_handle, char *usr_buffer,
return pybind11::none();
}
total_length = static_cast<size_t>(data_length);
if (total_length <= sizeof(TensorMetadata)) {
if (total_length < sizeof(TensorMetadata)) {
LOG(ERROR) << "Invalid data format: insufficient data for metadata";
return pybind11::none();
}
Expand All @@ -129,11 +129,11 @@ pybind11::object buffer_to_tensor(BufferHandle *buffer_handle, char *usr_buffer,
TensorDtype dtype_enum = static_cast<TensorDtype>(metadata.dtype);
size_t tensor_size = total_length - sizeof(TensorMetadata);

if (tensor_size == 0 || dtype_enum == TensorDtype::UNKNOWN) {
if (dtype_enum == TensorDtype::UNKNOWN) {
if (take_ownership) {
delete[] exported_data;
}
LOG(ERROR) << "Invalid tensor data or unknown dtype";
LOG(ERROR) << "Unknown tensor dtype";
return pybind11::none();
}

Expand Down
Loading