Skip to content

updated names to slab convention, Ref. #069 #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
XzzX merged 1 commit into from
Jan 22, 2026
Merged

updated names to slab convention, Ref. #069 #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions mrmd/util/IsInSymmetricSlab.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ class IsInSymmetricSlab
{
private:
const Point3D center_;
const real_t applicationRegionMin_;
const real_t applicationRegionMax_;
const real_t slabMin_;
const real_t slabMax_;

public:
KOKKOS_INLINE_FUNCTION
Expand All @@ -34,15 +34,11 @@ class IsInSymmetricSlab
auto dx = x - center_[0];
auto absDx = std::abs(dx);

return (absDx >= applicationRegionMin_ && absDx <= applicationRegionMax_);
return (absDx >= slabMin_ && absDx <= slabMax_);
}

IsInSymmetricSlab(const Point3D& center,
const real_t applicationRegionMin,
const real_t applicationRegionMax)
: center_(center),
applicationRegionMin_(applicationRegionMin),
applicationRegionMax_(applicationRegionMax)
IsInSymmetricSlab(const Point3D& center, const real_t slabMin, const real_t slabMax)
: center_(center), slabMin_(slabMin), slabMax_(slabMax)
{
}
};
Expand Down
6 changes: 3 additions & 3 deletions mrmd/util/IsInSymmetricSlab.test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ namespace util
TEST(IsInSymmetricSlab, testRegion)
{
Point3D center = {2_r, 3_r, 4_r};
const auto applicationRegionMin = 2_r;
const auto applicationRegionMax = 4_r;
auto isInSymmetricSlab = IsInSymmetricSlab(center, applicationRegionMin, applicationRegionMax);
const auto slabMin = 2_r;
const auto slabMax = 4_r;
auto isInSymmetricSlab = IsInSymmetricSlab(center, slabMin, slabMax);

EXPECT_TRUE(isInSymmetricSlab(4_r, 10_r, 10_r));
EXPECT_TRUE(isInSymmetricSlab(5.7_r, 10_r, 10_r));
Expand Down