-
Notifications
You must be signed in to change notification settings - Fork 2
Update interpolation input and output handling #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I just found that Cabana has some interpolation capabilities to begin with. Maybe we should fall back to those and get rid of my mediocre implementation eventually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the interpolation utility to update an existing “target” data::MultiHistogram in-place using interpolated values from an “input” data::MultiHistogram, as part of the smooth thermodynamic force interpolation work in #47.
Changes:
- Replace the previous
interpolate(...) -> MultiHistogramAPI withupdateInterpolate(input, target) -> void. - Update the interpolation implementation to write results into the provided
targethistogram grid. - Update the unit test to validate the new in-place update behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
mrmd/util/interpolation.hpp |
Updates the public API and documents the new in-place interpolation contract. |
mrmd/util/interpolation.cpp |
Implements in-place interpolation onto target’s grid using Kokkos parallelism. |
mrmd/util/interpolation.test.cpp |
Adapts the test to use updateInterpolate and compare against a reference histogram. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Part of #47.
Changed the interpolation function to
updateInterpolate, which now updates the data on a giventargetMultiHistogram with interpolated data frominputMultiHistogram.