fix(wasm): pass method code to JS by appending it as last byte#49
Open
12lockedin wants to merge 1 commit intoYM162:mainfrom
Open
fix(wasm): pass method code to JS by appending it as last byte#4912lockedin wants to merge 1 commit intoYM162:mainfrom
12lockedin wants to merge 1 commit intoYM162:mainfrom
Conversation
Previously the method_code from clean_pdf was discarded. A Serde-based approach was attempted but corrupted binary data (Vec<u8> serializes as a JS Array of numbers, not Uint8Array). Instead, append method_code as the last byte of the returned Vec<u8>. JS consumers slice it off: result.slice(0,-1) for PDF, result[result.length-1] for method. Also removes unused serde and serde-wasm-bindgen dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the method_code from clean_pdf was discarded. A Serde-based approach was attempted but corrupted binary data (Vec serializes as a JS Array of numbers, not Uint8Array).
Instead, append method_code as the last byte of the returned Vec. JS consumers slice it off: result.slice(0,-1) for PDF, result[result.length-1] for method.
Also removes unused serde and serde-wasm-bindgen dependencies.