Open
Conversation
noam-ai
changed the title
noam-ai
changed the title
YS-L
reviewed
Oct 13, 2024
Owner
YS-L
left a comment
YS-L
left a comment
There was a problem hiding this comment.
Thanks for the PR! I'm curious about the behavior of existing tools (less, bat, vim, IDEs, etc.) in this regard - do they handle bidirectional Unicode in a similar way?
In general, I'm inclined to display the content in the CSV file "as is," without additional interpretation. However, if this is a common feature in existing tools, I'm open to making csvlens consistent with that behavior.
| continue; | ||
| } | ||
| let bidi_info = BidiInfo::new(field, None); | ||
| let para = &bidi_info.paragraphs[0]; |
Owner
There was a problem hiding this comment.
Does this handle the case where there are multiple paragraphs?
Author
|
Either one of those tools does not handle it that way ... in all of them it shows the "Wrong Way" (vim, bat, less) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the unic_bidi Crate to add bidirectional unicode support.
Before:
After:
