Open
Conversation
YS-L
reviewed
Dec 7, 2025
Owner
There was a problem hiding this comment.
Thanks for the PR. A few thoughts:
I think this should probably follow the behaviour of 'copy rows', which doesn’t apply filters.(I was wrong, copying rows does apply filters)- Even with
clipboard_limit, fetching many rows can still stall the UI. This likely needs to run in a background thread.
The changes feel a bit complex for now, and I'm not fully comfortable merging this as is.
| Ok(values) | ||
| } | ||
|
|
||
| pub fn get_column_values_for_indices( |
Owner
There was a problem hiding this comment.
Reading a large number of rows this way without using the indexing in CsvLensReader can be slow. It also seems to duplicate quite a bit of the code there.
Contributor
Author
|
@YS-L |
Owner
|
Yes, revisiting this later could be a good idea. Thanks again for exploring this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @YS-L,
This PR addresses and implements Issue #150, which requested the ability to easily extract column data from the table view. I found this to be a highly valuable feature and decided to implement it.
This PR introduces functionality that allows users to copy the values of an entire selected column to the clipboard.
Key Features and Implementation Details
1. Column Copy-to-Clipboard
This feature is designed for speed and clarity in data extraction:
ykey will copy the values of that column to the clipboard.2. Clipboard Limit for Performance
To prevent potential performance issues and clipboard overflow when dealing with extremely large datasets, a sensible limit is enforced:
3. User Feedback and Status
After a copy operation, clear and informative feedback is provided to the user:
I look forward to your review and feedback on this implementation.
Kind regards.