Open
Conversation
YS-L
reviewed
Oct 1, 2023
| } else if self.index < self.spans.len() { | ||
| span = Some(self.spans.get(self.index).cloned().unwrap()); | ||
| self.index += 1; | ||
| match self.spans.get(self.index).cloned() { |
Owner
There was a problem hiding this comment.
Thanks @5ylar for the patch! Maybe I'm missing something, could you clarify in which scenario would the unwrap panic if we've checked that self.index is within bound? A test case would be helpful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.