fix: Allow url-encoded username and passwords

[katomaso]

Username and password can contain special symbols because the can be url-encoded

Changes included in this PR

URL unquote username and password by default so they can include / : and @.

Current behavior

If password container any of the URL special characters the URL got parsed badly and connection didn't work.

New behavior

URL is more compliant.

Impact

This would break any passwords containing % but allows for : / @ and other symbols.

Checklist

1. Does your submission pass the existing tests?
2. Are there new tests that cover these additions/changes?
3. Have you linted your code locally before submission?

[HerrMuellerluedenscheid]

Thanks!

[katomaso]

Actually it doesn't even break passwords that previously contained "%". Only if it was a valid url-quoting.

$ python -c 'from urllib.parse import unquote; print(unquote("pass%word"))'
'pass%word'

So this change is really just a fix - not a major change.

[HerrMuellerluedenscheid]

Actually it doesn't even break passwords that previously contained "%". Only if it was a valid url-quoting.

$ python -c 'from urllib.parse import unquote; print(unquote("pass%word"))'
'pass%word'

So this change is really just a fix - not a major change.

Great! I already approved that change. So you should be able to merge if I'm not mistaken. Or I do that... Ah I'll hit it. Thanks for the fix!