general days gcal export now repeats weekly #328#339
Open
JulienTD23 wants to merge 1 commit intoYaleComputerSociety:mainfrom
Open
general days gcal export now repeats weekly #328#339JulienTD23 wants to merge 1 commit intoYaleComputerSociety:mainfrom
JulienTD23 wants to merge 1 commit intoYaleComputerSociety:mainfrom
Conversation
jeet-parikh
requested changes
Feb 23, 2026
Collaborator
jeet-parikh
left a comment
jeet-parikh
left a comment
There was a problem hiding this comment.
Thanks Julien, this seems to work. From a maintainability standpoint and making this more flexible going forward, could you refactor all the relevant code into a separate ExportToGCalButton component? Personally don't love how this logic is being handled in the GroupViewPage.tsx file directly (obv not your fault, just a bad past decision haha)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.