Fix outdated holidays on DaySelect calendar (#327)#341
Open
ronaldmilgo wants to merge 1 commit intoYaleComputerSociety:mainfrom
Open
Fix outdated holidays on DaySelect calendar (#327)#341ronaldmilgo wants to merge 1 commit intoYaleComputerSociety:mainfrom
ronaldmilgo wants to merge 1 commit intoYaleComputerSociety:mainfrom
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
jeet-parikh
requested changes
Feb 22, 2026
Collaborator
jeet-parikh
left a comment
jeet-parikh
left a comment
There was a problem hiding this comment.
This is amazing Ronald. The dynamic holiday generation works great!
Quick change - It seems like the Yale breaks (Fall, November, Spring) don't match up with the official dates.
Can you double check and make sure they align with the information on this page: https://yalecollege.yale.edu/academics/academic-calendar/future-and-future-provisional-academic-calendars
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Holidays were hardcoded for 2000, so floating and academic holidays showed on the wrong days in other years.
New holidays.ts: Year-aware logic for federal holidays (fixed + floating: MLK, Memorial Day, Labor Day, Thanksgiving, Good Friday, Juneteenth) and Yale academic breaks (Oct/Nov/Spring) from the official calendar.
CircleComponent now uses getHolidayForDate(date) so each day is evaluated for the correct year.
Holidays on the calendar now match the correct dates for the year being viewed.