Skip to content

Submit homework solution#447

Open
DenisIvanov116 wants to merge 1 commit intoYandex-Practicum:mainfrom
DenisIvanov116:homework
Open

Submit homework solution#447
DenisIvanov116 wants to merge 1 commit intoYandex-Practicum:mainfrom
DenisIvanov116:homework

Conversation

@DenisIvanov116
Copy link
Copy Markdown

Решение с тестами для 7 спринта

Copy link
Copy Markdown

@dirtymew dirtymew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Привет Денис

работа принята но есть замечания см PR

и PR нужно делать в свой форк, а не репозиторий задания

Comment thread main.go
"moscow": {"CoffeeShop1", "CoffeeShop2", "CoffeeShop3", "CoffeeShop4"},
}

func mainHandle(w http.ResponseWriter, r *http.Request) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

этот код стоило оставить как был и не менять

Comment thread precode_test.go
@@ -0,0 +1,52 @@
package main
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

файл для тестов неверно назван

main_test.go

Comment thread precode_test.go
handler.ServeHTTP(rr, req)

require.Equal(t, http.StatusOK, rr.Code, "ожидается код ответа 200")
assert.NotEmpty(t, rr.Body.String(), "тело ответа не должно быть пустым")
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assert.NotEmpty(t, rr.Body.String)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants