Stellar Burgers Task 1 (unit tests)#698
Open
debatableoutcome wants to merge 1 commit intoYandex-Practicum:mainfrom
Open
Stellar Burgers Task 1 (unit tests)#698debatableoutcome wants to merge 1 commit intoYandex-Practicum:mainfrom
debatableoutcome wants to merge 1 commit intoYandex-Practicum:mainfrom
Conversation
AlexKitIt
reviewed
Feb 19, 2026
| ('white bun', 200), | ||
| ('red bun', 300), | ||
| ]) | ||
| def test_bun_getters(name, price): |
There was a problem hiding this comment.
Нужно исправить: здесь и далее по тестам: тестовые методы в модулях объединяются в тестовые классы, необходимо создать в каждом тестовом модуле тестовые классы и разместить в них методы, даже если тестовый метод только один
AlexKitIt
reviewed
Feb 19, 2026
Comment on lines
+13
to
+14
| assert bun.get_name() == name | ||
| assert bun.get_price() == price |
There was a problem hiding this comment.
Нужно исправить: здесь и далее: это юнит тесты, на каждый метод должен быть отдельный тест
AlexKitIt
reviewed
Feb 19, 2026
|
|
||
| burger.add_ingredient(ingredient) | ||
|
|
||
| assert burger.get_price() == expected |
There was a problem hiding this comment.
Нужно исправить: отсутствуют тесты на проверку метода get_recipe. Каждый метод должен быть покрыт отдельным тестом
AlexKitIt
reviewed
Feb 19, 2026
Comment on lines
+5
to
+18
| @pytest.fixture | ||
| def bun_mock(): | ||
| bun = Mock() | ||
| bun.get_name.return_value = 'black bun' | ||
| bun.get_price.return_value = 100 | ||
| return bun | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def ingredient_mock(): | ||
| ingredient = Mock() | ||
| ingredient.get_type.return_value = 'SAUCE' | ||
| ingredient.get_name.return_value = 'hot sauce' | ||
| ingredient.get_price.return_value = 50 |
There was a problem hiding this comment.
Нужно исправить: фикстуры написаны но нигде не используются
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.