Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: #135
Solution: While familiarizing with the python email library, I noticed that
get_body()accepts a parameter for which MIME type you want to receive. I found that adding this parameter and removing the current multipart parser works for my use case. I also added a config option to switch between text/html-preferred.Testing: I only tested on my personal use case. I'm not sure why
_getmultiparttextexists in the first place; maybe there are some cases whereget_body()fails? Maybe when this was first implementedget_body()did not parse multipart messages?I wasn't sure if the config option should be global or per-address.