Tweak admin redesign 2#15623
Merged
rolf-yoast merged 58 commits intofeature/admin-redesignfrom Jul 17, 2020
Merged
Conversation
Remove the table-scrollable
Which does not play nice with the person-dropdown when selecting a user above.
To restore general sanity when switching.
Contributor
Contributor
Contributor
|
The upsell looks good 👍 |
…ak-admin-redesign-2 # Conflicts: # admin/views/class-yoast-feature-toggles.php # js/src/components/WordPressUserSelectorSearchAppearance.js # js/tests/__snapshots__/advancedSettings.test.js.snap # js/tests/components/__snapshots__/LocalSEOUpsell.test.js.snap # js/tests/components/__snapshots__/SnippetPreviewSection.test.js.snap
Contributor
|
Looks good 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Context
This is linked to Yoast/javascript#751
Todo
Design
Category URLsto a collapsible box#444needs to be#303030Mobile design
General finishing up
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
This PR can be tested by following these steps:
yarn link-monorepoand check out the branch of that PRgrunt build:js build:cssin the Plugin to build the assets after linking and checking out the branch on the monorepo.UI changes
Documentation
Quality assurance
Fixes #