Skip to content

Add string typecheck before checking length prop on authorname #17523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marijnyoast merged 1 commit into from
Oct 18, 2021
Merged

Add string typecheck before checking length prop on authorname #17523

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/social-metadata-previews/src/facebook/FacebookSiteAndAuthorNames.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import React, { Fragment } from "react";
import styled from "styled-components";
import PropTypes from "prop-types";
import { __, sprintf } from "@wordpress/i18n";
import { isString } from "lodash";

/* Internal dependencies */
import FacebookAuthorName from "./FacebookAuthorName";
Expand Down Expand Up @@ -59,11 +60,13 @@ function renderFacebookAuthorName( authorName ) {
* Renders a FacebookSiteAndAuthorNames component.
*
* @param {object} props The props.
* @param {string} props.authorName The author's name.
* @param {string} props.siteUrl The site url.
*
* @returns {React.Element} The rendered element.
*/
const FacebookSiteAndAuthorNames = ( props ) => {
const hasAuthorName = props.authorName.length > 0;
const hasAuthorName = isString( props.authorName ) && props.authorName.length > 0;
const screenReaderText = hasAuthorName
/* Translators: 1: site name, 2: post author name */
? sprintf( __( "%1$s by %2$s", "yoast-components" ), props.siteUrl, props.authorName )
Expand Down