FetchAPI and Comparer#59
Open
YogiBear52 wants to merge 1 commit intomasterfrom
Open
Conversation
levinlev
reviewed
Aug 13, 2019
| }) | ||
| describe('with costume comparer', () => { | ||
| let costumeFeaturesComparerReverse = (a: Feature, b: Feature): number => { return a.name.localeCompare(b.name) * (-1)}; | ||
| let expectedIdOrder: string[] = ["ID1", "ID2", "ID3"]; |
Collaborator
There was a problem hiding this comment.
The order shoul be the opposite, since you use the custome (reverse) comparer
levinlev
reviewed
Aug 13, 2019
| } | ||
| } | ||
|
|
||
| private getFeaturesCategoryComparerFunc(): (a: FeaturesCategory, b: FeaturesCategory) => number { |
Collaborator
There was a problem hiding this comment.
There is a way to pass default values to properties.
look here:
https://stackoverflow.com/questions/37282159/default-property-value-in-react-component-using-typescript
| return this.props.featuresCategoryCompareFn ? this.props.featuresCategoryCompareFn : FeaturesCategory.Compare; | ||
| } | ||
|
|
||
| private getFeaturesComparerFunc(): (a: Feature, b: Feature) => number { |
Collaborator
There was a problem hiding this comment.
There is a way to pass default values to properties. look here: https://stackoverflow.com/questions/37282159/default-property-value-in-react-component-using-typescript
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invoro now can get Fetch Interceptor , FeaturesComparer and categories comparer