Fix New GH Actions

.github/workflows/nuget-publish.yml

@@ -26,12 +26,18 @@ jobs:
         with:
           dotnet-version: 8.0.x
 
+      - name: Install Android workload
+        run: dotnet workload install android --ignore-failed-sources
+
       - name: Restore
         run: dotnet restore ./src/Main/RSSDP.sln
 
       - name: Build
         run: dotnet build ./src/Main/RSSDP.sln --configuration Release --no-restore
 
+      - name: Test
+        run: dotnet test ./src/Main/RSSDP.sln --configuration Release --no-build --logger "trx;LogFileName=test_results.trx" --results-directory TestResults
+
       - name: Determine Version and Project Path
         id: meta
         shell: bash
@@ -56,7 +62,7 @@ jobs:
       - name: Publish to NuGet.org
         env:
           NUGET_API_KEY: ${{ secrets.NUGET_API_KEY }}
-        run: dotnet nuget push "./artifacts/*.nupkg" --source "https://api.nuget.org/v3/index.json" --api-key "$NUGET_API_KEY" --skip-duplicate
+        run: dotnet nuget push artifacts\Rssdp.*.nupkg --source https://api.nuget.org/v3/index.json --api-key $env:NUGET_API_KEY --skip-duplicate
 
       - name: Upload Package Artifact
         if: always()

.github/workflows/pr-gate.yml

@@ -23,6 +23,9 @@ jobs:
             8.0.x
             6.0.x
 
+      - name: Install Android workload
+        run: dotnet workload install android --ignore-failed-sources
+
       - name: Cache NuGet
         uses: actions/cache@v4
         with:
@@ -38,13 +41,12 @@ jobs:
         run: dotnet build ./src/Main/RSSDP.sln --configuration Release --no-restore
 
       - name: Test
-        run: dotnet test ./src/Main/RSSDP.sln --configuration Release --no-build --logger "trx;LogFileName=test_results.trx"
+        run: dotnet test ./src/Main/RSSDP.sln --configuration Release --no-build --logger "trx;LogFileName=test_results.trx" --results-directory TestResults
 
       - name: Publish Test Results
         if: always()
         uses: actions/upload-artifact@v4
         with:
           name: test-results
-          path: |
-            **/TestResults/*.trx
-            **/TestResults/**/*.trx
+          path: TestResults/**/*.trx
+          if-no-files-found: warn

docs/manifest.json

@@ -24,7 +24,7 @@
           "hash": "99ckxg02dafTH9nwfNcM3+EW6+6OT7eAntv7e+eAw1M="
         }
       },
-      "is_incremental": false,
+      "is_incremental": true,
       "version": ""
     },
     {
@@ -36,7 +36,7 @@
           "hash": "lA+D0ov1AuxIeiIRjNe6INd51sXFRnKwse3JvVHtBMc="
         }
       },
-      "is_incremental": false,
+      "is_incremental": true,
       "version": ""
     },
     {
@@ -72,7 +72,7 @@
           "hash": "FjfzVTFVpsd29KnX7ZXM5XpUSA0PbivvdLDwaNXbtRM="
         }
       },
-      "is_incremental": false,
+      "is_incremental": true,
       "version": ""
     },
     {
@@ -84,7 +84,7 @@
           "hash": "sOWMwUlh5r2IlSoPR4cwUCPGj1GSd86uEc1W7GJZXMU="
         }
       },
-      "is_incremental": false,
+      "is_incremental": true,
       "version": ""
     },
     {
@@ -120,7 +120,7 @@
           "hash": "eWz9C1JMOjv6zeqLvYtDmDJBMO1Qx4HMSBRf+XtVIoo="
         }
       },
-      "is_incremental": false,
+      "is_incremental": true,
       "version": ""
     },
     {
@@ -599,32 +599,30 @@
           "hash": "f9a4x1d92blNB6PDNbfGHtTJFnV93H9sBpeptN0ZqTo="
         }
       },
-      "is_incremental": false,
+      "is_incremental": true,
       "version": ""
     }
   ],
   "incremental_info": [
     {
       "status": {
-        "can_incremental": false,
-        "details": "Cannot build incrementally because last build info is missing.",
+        "can_incremental": true,
         "incrementalPhase": "build",
         "total_file_count": 0,
-        "skipped_file_count": 0,
-        "full_build_reason_code": "NoAvailableBuildCache"
+        "skipped_file_count": 0
       },
       "processors": {
         "ConceptualDocumentProcessor": {
-          "can_incremental": false,
+          "can_incremental": true,
           "incrementalPhase": "build",
           "total_file_count": 1,
-          "skipped_file_count": 0
+          "skipped_file_count": 1
         },
         "ManagedReferenceDocumentProcessor": {
-          "can_incremental": false,
+          "can_incremental": true,
           "incrementalPhase": "build",
           "total_file_count": 48,
-          "skipped_file_count": 0
+          "skipped_file_count": 14
         },
         "ResourceDocumentProcessor": {
           "can_incremental": false,
@@ -644,8 +642,8 @@
     },
     {
       "status": {
-        "can_incremental": false,
-        "details": "Cannot support incremental post processing, the reason is: last post processor info is null.",
+        "can_incremental": true,
+        "details": "Can support incremental post processing.",
         "incrementalPhase": "postProcessing",
         "total_file_count": 0,
         "skipped_file_count": 0

src/Main/Lib/HttpRequestParser.cs

@@ -37,9 +37,11 @@ public override System.Net.Http.HttpRequestMessage Parse(string data)
 
 				return retVal;
 			}
-			finally
+			catch
 			{
 				retVal?.Dispose();
+
+				throw;
 			}
 		}
 

src/Main/Lib/Rssdp.csproj

@@ -9,7 +9,7 @@
 		<GeneratePackageOnBuild>True</GeneratePackageOnBuild>
 		<PackageId>Rssdp</PackageId>
 		<Title>Rssdp</Title>
-		<Version>$(VersionPrefix)5.0.0-beta2</Version>
+		<Version>$(VersionPrefix)5.0.0-beta3</Version>
 		<Authors>Troy Willmot</Authors>
 		<Owners>Yortw</Owners>
 		<Description>Really Simple Service Discovery Protocol - a 100% .Net implementation of the SSDP protocol for publishing custom/basic devices, and discovering all device types on a network.</Description>
@@ -53,6 +53,7 @@
 		<SupportedOSPlatformVersion Condition="$(TargetFramework.StartsWith('net8.0-ios'))">11.0</SupportedOSPlatformVersion>
 		<Product>Really Simple Service Discovery Protocol</Product>
 		<GenerateDocumentationFile>True</GenerateDocumentationFile>
+		<SymbolPackageFormat>snupkg</SymbolPackageFormat>
 	</PropertyGroup>
 
 	<ItemGroup>

src/Main/Lib/api/Rssdp.ISsdpLogger.yml

@@ -19,7 +19,7 @@ items:
   source:
     id: ISsdpLogger
     path: ''
-    startLine: 2000
+    startLine: 2002
   assemblies:
   - cs.temp.dll
   namespace: Rssdp
@@ -48,7 +48,7 @@ items:
   source:
     id: LogInfo
     path: ''
-    startLine: 2007
+    startLine: 2009
   assemblies:
   - cs.temp.dll
   namespace: Rssdp
@@ -76,7 +76,7 @@ items:
   source:
     id: LogVerbose
     path: ''
-    startLine: 2013
+    startLine: 2015
   assemblies:
   - cs.temp.dll
   namespace: Rssdp
@@ -104,7 +104,7 @@ items:
   source:
     id: LogWarning
     path: ''
-    startLine: 2019
+    startLine: 2021
   assemblies:
   - cs.temp.dll
   namespace: Rssdp
@@ -132,7 +132,7 @@ items:
   source:
     id: LogError
     path: ''
-    startLine: 2025
+    startLine: 2027
   assemblies:
   - cs.temp.dll
   namespace: Rssdp

src/Main/Lib/api/Rssdp.Infrastructure.HttpRequestParser.yml

@@ -102,7 +102,7 @@ items:
   source:
     id: ParseStatusLine
     path: ''
-    startLine: 1553
+    startLine: 1555
   assemblies:
   - cs.temp.dll
   namespace: Rssdp.Infrastructure
@@ -140,7 +140,7 @@ items:
   source:
     id: IsContentHeader
     path: ''
-    startLine: 1574
+    startLine: 1576
   assemblies:
   - cs.temp.dll
   namespace: Rssdp.Infrastructure

src/Main/Lib/api/Rssdp.Infrastructure.HttpResponseParser.yml

@@ -18,7 +18,7 @@ items:
   source:
     id: HttpResponseParser
     path: ''
-    startLine: 1593
+    startLine: 1595
   assemblies:
   - cs.temp.dll
   namespace: Rssdp.Infrastructure
@@ -65,7 +65,7 @@ items:
   source:
     id: Parse
     path: ''
-    startLine: 1612
+    startLine: 1614
   assemblies:
   - cs.temp.dll
   namespace: Rssdp.Infrastructure
@@ -103,7 +103,7 @@ items:
   source:
     id: IsContentHeader
     path: ''
-    startLine: 1639
+    startLine: 1641
   assemblies:
   - cs.temp.dll
   namespace: Rssdp.Infrastructure
@@ -141,7 +141,7 @@ items:
   source:
     id: ParseStatusLine
     path: ''
-    startLine: 1649
+    startLine: 1651
   assemblies:
   - cs.temp.dll
   namespace: Rssdp.Infrastructure

src/Main/Lib/api/Rssdp.Infrastructure.ISocketFactory.yml

@@ -18,7 +18,7 @@ items:
   source:
     id: ISocketFactory
     path: ''
-    startLine: 1703
+    startLine: 1705
   assemblies:
   - cs.temp.dll
   namespace: Rssdp.Infrastructure
@@ -47,7 +47,7 @@ items:
   source:
     id: CreateUdpSocket
     path: ''
-    startLine: 1711
+    startLine: 1713
   assemblies:
   - cs.temp.dll
   namespace: Rssdp.Infrastructure
@@ -78,7 +78,7 @@ items:
   source:
     id: CreateUdpMulticastSocket
     path: ''
-    startLine: 1719
+    startLine: 1721
   assemblies:
   - cs.temp.dll
   namespace: Rssdp.Infrastructure
@@ -112,7 +112,7 @@ items:
   source:
     id: DeviceNetworkType
     path: ''
-    startLine: 1725
+    startLine: 1727
   assemblies:
   - cs.temp.dll
   namespace: Rssdp.Infrastructure