Skip to content

fix(Dockerfile): optimize user creation and file copying for better l… #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yosoyepa merged 2 commits into from
Dec 4, 2025
Merged

fix(Dockerfile): optimize user creation and file copying for better l… #28

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b63d9f
fix(Dockerfile): optimize user creation and file copying for better l…
Yosoyepa Dec 4, 2025
0bb8bec
Merge branch 'main' into feature/ProdDeploy
Yosoyepa Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions backend/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ ENV PYTHONUNBUFFERED=1 \
PYTHONDONTWRITEBYTECODE=1 \
PIP_NO_CACHE_DIR=1 \
PIP_DISABLE_PIP_VERSION_CHECK=1 \
# Cloud Run uses PORT env variable
PORT=8080

# Set working directory
Expand All @@ -28,22 +27,23 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
&& rm -rf /var/lib/apt/lists/* \
&& apt-get clean

# Create non-root user first (before copying files)
RUN useradd -m -u 1000 appuser

# Copy requirements first (for layer caching)
COPY requirements.txt .
COPY --chown=appuser:appuser requirements.txt .

# Install Python dependencies
RUN pip install --no-cache-dir -r requirements.txt

# Copy application code
COPY . .
COPY --chown=appuser:appuser . .

# Create non-root user (Cloud Run best practice)
RUN useradd -m -u 1000 appuser && chown -R appuser:appuser /app
# Switch to non-root user
USER appuser

# Cloud Run will set PORT dynamically, expose default
EXPOSE 8080

# Cloud Run handles health checks via HTTP, no HEALTHCHECK needed
# Use shell form to allow $PORT expansion at runtime
CMD uvicorn src.main:app --host 0.0.0.0 --port $PORT
# Use exec form for proper signal handling
CMD ["sh", "-c", "exec uvicorn src.main:app --host 0.0.0.0 --port $PORT"]