Claude/review project code 01 gyhv s8 wg ve gu1u y1 pz9 sos#21
Open
joshbox3 wants to merge 4 commits intoYu-Fangxu:mainfrom
Open
Claude/review project code 01 gyhv s8 wg ve gu1u y1 pz9 sos#21joshbox3 wants to merge 4 commits intoYu-Fangxu:mainfrom
joshbox3 wants to merge 4 commits intoYu-Fangxu:mainfrom
Conversation
Contains: - Jupyter notebook for A100 GPU execution (SPSA gradient-free approach) - GPT-4 selection module for multi-sample attack selection - Visualization tools for publication-quality plots - Team documentation (Battle Plan, Team Guide) - Presentation materials
Changes: - Renamed notebook to cold_attack_replication.ipynb - Simplified documentation (project_notes.md, team_guide.md, presentation_notes.md) - Simplified Python files (gpt4_eval.py, plot_results.py) - Removed overly complex files (diagrams, JSX component) - Made all docs more casual/student-like
Replace SPSA gradient-free approach with real backpropagation: - Add epsilon = nn.Parameter optimized with Adam optimizer - Remove torch.no_grad() from soft_forward and soft_forward_xyz - Gradients flow through: epsilon -> softmax -> embedding -> model - Properly implement Langevin dynamics with gradient descent + noise Key changes: - util.py: Real gradient flow through embed_inputs and soft_forward - decoding_suffix.py: Use loss.backward() and optim.step() - Removed duplicate util.py cell (was written twice) - Cleaned up all cells to be student-style without emojis This should significantly improve ASR compared to SPSA version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leaned up the code