[autopatch] Automatic patch to simplify proxy_pass/fastcgi_pass options in nginx.conf (PLEASE DOUBLE CHECK BEFORE MERGING)
#21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic PR
This is an automated patch to automatically use the new nginx conf snippets that should be used for apps that use
proxy_passandfastcgi_pass, shipped in YunoHost >= 12.1.38:fastcgi_params_no_authfastcgi_params_with_authproxy_params_no_authproxy_params_with_authIn particular they are meant to:
fastcgi_param SCRIPT_FILENAME [...]orproxy_set_header X-Real-IP $remote_addr;..._no_authparams or_with_authparams, depending if the app is to support SSO integration or not. In particular, PHP apps should not have afastcgi_param REMOTE_USERstatement in their nginx conf.REMOTE_USERif often the info used by PHP apps to know which user is connected. Thefastcgi_params_with_authsnippet properly defines this variable using the info from SSOwat.This auto-patch should automatically have used the
_no_author_with_authdepending on the value ofssofrom themanifest.toml. PLEASE CAREFULLY DOUBLE CHECK wether or not this app is supposed to integrate with the SSO or not, and tweak theincludestatements accordingly if necessary.Moreover, some special cases may not have been handled automagically, such as
locationblock may require the auth information, but not others ; orFinally, please bear in mind that this is just an automated patch and it may not work out of the box.