Skip to content

Remove Eigen3 minimum version requirement in CMake#163

Merged
ptahmose merged 2 commits intoZEISS:mainfrom
ptahmose:jbl/remove_version_requirement_for_eigen3
Jan 30, 2026
Merged

Remove Eigen3 minimum version requirement in CMake#163
ptahmose merged 2 commits intoZEISS:mainfrom
ptahmose:jbl/remove_version_requirement_for_eigen3

Conversation

@ptahmose
Copy link
Contributor

@ptahmose ptahmose commented Jan 30, 2026

Description

Previously, CMakeLists.txt required Eigen3 version 3.3 or higher. Now, it will accept any available version of Eigen3 found. However - with version 5, there was a version mismatch required. This now removes the version requirement, proper operation with latest version 5 was checked for.
This is a build-system-only change.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

locally

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I updated the documentation.
  • I updated the version of libCZI following Versioning of libCZI depending on the type of change
    • Bug fix -> PATCH
    • New feature -> MINOR
    • Breaking change -> MAJOR
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Previously, CMakeLists.txt required Eigen3 version 3.3 or higher.
Now, it will accept any available version of Eigen3 found.
@ptahmose ptahmose added the cla Contributor License Agreement sent to Admin label Jan 30, 2026
Prevents API version compatibility issues by disabling version
checks when starting the Azurite blob service in CI. This helps
ensure tests run smoothly with newer client tools or SDKs.
@ptahmose ptahmose marked this pull request as ready for review January 30, 2026 11:16
@ptahmose ptahmose merged commit 16b30e7 into ZEISS:main Jan 30, 2026
10 checks passed
@ptahmose ptahmose deleted the jbl/remove_version_requirement_for_eigen3 branch January 30, 2026 11:36
@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.38%. Comparing base (4746709) to head (a34e9d6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #163   +/-   ##
=======================================
  Coverage   66.38%   66.38%           
=======================================
  Files          96       96           
  Lines       12365    12365           
=======================================
  Hits         8209     8209           
  Misses       4156     4156           
Flag Coverage Δ
windows-latest 66.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla Contributor License Agreement sent to Admin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants