Remove Eigen3 minimum version requirement in CMake#163
Merged
ptahmose merged 2 commits intoZEISS:mainfrom Jan 30, 2026
Merged
Conversation
Previously, CMakeLists.txt required Eigen3 version 3.3 or higher. Now, it will accept any available version of Eigen3 found.
Prevents API version compatibility issues by disabling version checks when starting the Azurite blob service in CI. This helps ensure tests run smoothly with newer client tools or SDKs.
DaveyJonesBitPail
approved these changes
Jan 30, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
=======================================
Coverage 66.38% 66.38%
=======================================
Files 96 96
Lines 12365 12365
=======================================
Hits 8209 8209
Misses 4156 4156
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, CMakeLists.txt required Eigen3 version 3.3 or higher. Now, it will accept any available version of Eigen3 found. However - with version 5, there was a version mismatch required. This now removes the version requirement, proper operation with latest version 5 was checked for.
This is a build-system-only change.
Type of change
How Has This Been Tested?
locally
Checklist: